Skip to content

Commit 70a4d10

Browse files
committed
reenable some skipped tests.
1 parent 89cd638 commit 70a4d10

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildANetCoreApp.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void It_targets_the_right_shared_framework(string targetFramework, string
4848
}
4949

5050
// Test behavior when implicit version differs for framework-dependent and self-contained apps
51-
[Theory(Skip = "https://github.com/dotnet/sdk/issues/45417")]
51+
[Theory]
5252
[InlineData("netcoreapp1.0", false, true, "1.0.5")]
5353
[InlineData("netcoreapp1.0", true, true, "1.0.16")]
5454
[InlineData("netcoreapp1.0", false, false, "1.0.5")]

test/dotnet-new.Tests/DotnetNewListTests.Approval.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ namespace Microsoft.DotNet.Cli.New.IntegrationTests
77
{
88
public partial class DotnetNewListTests
99
{
10-
#pragma warning disable xUnit1004 // Test methods should not be skipped
11-
[Theory(Skip = "https://github.com/dotnet/sdk/issues/45406")]
10+
[Theory]
1211
[InlineData("-l")]
1312
[InlineData("--list")]
1413
public Task BasicTest_WhenLegacyCommandIsUsed(string commandName)
@@ -28,7 +27,7 @@ public Task BasicTest_WhenLegacyCommandIsUsed(string commandName)
2827
.DisableRequireUniquePrefix();
2928
}
3029

31-
[Fact(Skip = "https://github.com/dotnet/sdk/issues/45406")]
30+
[Fact]
3231
public Task BasicTest_WhenListCommandIsUsed()
3332
{
3433
CommandResult commandResult = new DotnetNewCommand(_log, "list")
@@ -42,7 +41,6 @@ public Task BasicTest_WhenListCommandIsUsed()
4241

4342
return Verify(commandResult.StdOut).UniqueForOSPlatform();
4443
}
45-
#pragma warning restore xUnit1004
4644

4745
[Fact]
4846
public Task Constraints_CanShowMessageIfTemplateGroupIsRestricted()

0 commit comments

Comments
 (0)