Skip to content

Commit 7573fca

Browse files
authored
Re-enable VMR signing (#44437)
1 parent b0bf7b7 commit 7573fca

File tree

2 files changed

+24
-2
lines changed

2 files changed

+24
-2
lines changed

eng/pipelines/templates/jobs/vmr-build.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ parameters:
4848
- name: sign
4949
displayName: True when build output should be signed
5050
type: boolean
51-
# Temporarily set to false to unblock build: https://github.com/dotnet/runtime/issues/109178
52-
default: false
51+
default: true
5352

5453
# Overrides the rid that is produced by the build.
5554
- name: targetRid
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
From b8cf520d147416fa6a778eb993cb7d6f3fd23394 Mon Sep 17 00:00:00 2001
2+
From: Jeremy Koritzinsky <[email protected]>
3+
Date: Thu, 24 Oct 2024 15:34:02 -0700
4+
Subject: [PATCH] Forward the ForceDryRunSigning variable down to the runtime
5+
inner build
6+
7+
Backport: https://github.com/dotnet/runtime/pull/109206
8+
---
9+
eng/DotNetBuild.props | 1 +
10+
1 file changed, 1 insertion(+)
11+
12+
diff --git a/eng/DotNetBuild.props b/eng/DotNetBuild.props
13+
index 6e29b64f9a422..0a75f2938bf6b 100644
14+
--- a/eng/DotNetBuild.props
15+
+++ b/eng/DotNetBuild.props
16+
@@ -78,6 +78,7 @@
17+
<InnerBuildArgs Condition="'$(ContinuousIntegrationBuild)' != ''">$(InnerBuildArgs) /p:ContinuousIntegrationBuild=$(ContinuousIntegrationBuild)</InnerBuildArgs>
18+
<InnerBuildArgs Condition="'$(PortableBuild)' != ''">$(InnerBuildArgs) /p:PortableBuild=$(PortableBuild)</InnerBuildArgs>
19+
<InnerBuildArgs Condition="'$(RestoreConfigFile)' != ''">$(InnerBuildArgs) /p:RestoreConfigFile=$(RestoreConfigFile)</InnerBuildArgs>
20+
+ <InnerBuildArgs Condition="'$(ForceDryRunSigning)' != ''">$(InnerBuildArgs) /p:ForceDryRunSigning=$(ForceDryRunSigning)</InnerBuildArgs>
21+
22+
<!-- Pass locations for assets, packages and symbols -->
23+
<InnerBuildArgs Condition="'$(SourceBuiltAssetsDir)' != ''">$(InnerBuildArgs) /p:SourceBuiltAssetsDir=$(SourceBuiltAssetsDir)</InnerBuildArgs>

0 commit comments

Comments
 (0)