Clarify assertion message in a run-file test (#50169)

jjonescz · Copilot · web-flow · commit 7e54c25eeb91 · 2025-08-13T09:53:09.000+02:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/test/dotnet.Tests/CommandTests/Run/RunFileTests.cs b/test/dotnet.Tests/CommandTests/Run/RunFileTests.cs
@@ -2151,7 +2151,7 @@ public static IEnumerable<string> GetPathsOfCscInputsFromNuGetCache()
             {
                 Log.WriteLine($"{codeFilePath.FullName} needs to be updated:");
                 Log.WriteLine(newText);
-                if (Environment.GetEnvironmentVariable("CI") == "true")
+                if (Env.GetEnvironmentVariableAsBool("CI"))
                 {
                     throw new InvalidOperationException($"Not updating file in CI: {codeFilePath.FullName}");
                 }
@@ -2278,7 +2278,7 @@ Hello from {programName}
             var msbuildFileText = File.ReadAllText(msbuildFile);
             if (cscOnlyFileText.ReplaceLineEndings() != msbuildFileText.ReplaceLineEndings())
             {
-                Log.WriteLine($"File differs between MSBuild and CSC-only runs: {cscOnlyFile}");
+                Log.WriteLine($"File differs between MSBuild and CSC-only runs (if this is expected, find the template in '{nameof(CSharpCompilerCommand)}.cs' and update it): {cscOnlyFile}");
                 const int limit = 3_000;
                 if (cscOnlyFileText.Length < limit && msbuildFileText.Length < limit)
                 {

Original file line number	Diff line number	Diff line change
`@@ -2151,7 +2151,7 @@ public static IEnumerable<string> GetPathsOfCscInputsFromNuGetCache()`
`2151`	`2151`	`{`
`2152`	`2152`	`Log.WriteLine($"{codeFilePath.FullName} needs to be updated:");`
`2153`	`2153`	`Log.WriteLine(newText);`
`2154`		`- if (Environment.GetEnvironmentVariable("CI") == "true")`
	`2154`	`+ if (Env.GetEnvironmentVariableAsBool("CI"))`
`2155`	`2155`	`{`
`2156`	`2156`	`throw new InvalidOperationException($"Not updating file in CI: {codeFilePath.FullName}");`
`2157`	`2157`	`}`
`@@ -2278,7 +2278,7 @@ Hello from {programName}`
`2278`	`2278`	`var msbuildFileText = File.ReadAllText(msbuildFile);`
`2279`	`2279`	`if (cscOnlyFileText.ReplaceLineEndings() != msbuildFileText.ReplaceLineEndings())`
`2280`	`2280`	`{`
`2281`		`- Log.WriteLine($"File differs between MSBuild and CSC-only runs: {cscOnlyFile}");`
	`2281`	`+ Log.WriteLine($"File differs between MSBuild and CSC-only runs (if this is expected, find the template in '{nameof(CSharpCompilerCommand)}.cs' and update it): {cscOnlyFile}");`
`2282`	`2282`	`const int limit = 3_000;`
`2283`	`2283`	`if (cscOnlyFileText.Length < limit && msbuildFileText.Length < limit)`
`2284`	`2284`	`{`