Skip to content

Commit 8305b9d

Browse files
MiYanniMiYanni
authored
Reenable passed tests with skip attribute set as string (#41753)
2 parents 05acfc8 + da249a9 commit 8305b9d

File tree

9 files changed

+40
-42
lines changed

9 files changed

+40
-42
lines changed

‎test/EndToEnd-Installer.Tests/ProjectBuildTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ public void ItCanCreateAndBuildTemplatesWithDefaultFramework(string templateName
358358
[InlineData("wpflib", "VB")]
359359
[InlineData("wpfcustomcontrollib")]
360360
[InlineData("wpfcustomcontrollib", "C#")]
361-
[InlineData("wpfcustomcontrollib", "VB", Skip = "Skipping since the Generic.xaml it creates from the template fails to compile.")]
361+
[InlineData("wpfcustomcontrollib", "VB")]
362362
[InlineData("wpfusercontrollib")]
363363
[InlineData("wpfusercontrollib", "C#")]
364364
[InlineData("wpfusercontrollib", "VB")]

‎test/EndToEnd-Installer.Tests/TelemetryOptOutDefaultTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace EndToEnd.Tests
99
{
1010
public class TelemetryOptOutDefault : TestBase
1111
{
12-
[Fact(Skip = "TODO: This test can only be ran in CI because the local build does not adjust telemetry settings.")]
12+
[Fact]
1313
public void TelemetryOptOutDefaultAttribute()
1414
{
1515
var versionCommand = new DotnetCommand().ExecuteWithCapturedOutput("--version");

‎test/Microsoft.DotNet.Configurer.UnitTests/GivenAFirstTimeUseNoticeSentinel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public GivenAFirstTimeUseNoticeSentinel()
1818
_fileSystemMockBuilder = FileSystemMockBuilder.Create();
1919
}
2020

21-
[Fact(Skip = "Product.Version not set correctly when running tests")]
21+
[Fact]
2222
public void TheSentinelHasTheCurrentVersionInItsName()
2323
{
2424
FirstTimeUseNoticeSentinel.SENTINEL.Should().Contain($"{Product.Version}");

‎test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BlazorLegacyIntegrationTest60.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace Microsoft.NET.Sdk.BlazorWebAssembly.Tests
99
public class BlazorLegacyIntegrationTest60(ITestOutputHelper log)
1010
: IsolatedNuGetPackageFolderAspNetSdkBaselineTest(log, nameof(BlazorLegacyIntegrationTest60))
1111
{
12-
[CoreMSBuildOnlyFact(Skip = "The Runtime pack resolves to 8.0 instead of 9.0")]
12+
[CoreMSBuildOnlyFact]
1313
public void Build60Hosted_Works()
1414
{
1515
// Arrange

‎test/Microsoft.TemplateEngine.Cli.UnitTests/TemplateSearchCoordinatorTests.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -444,9 +444,7 @@ public async Task CacheSearchLanguageMismatchFilterTest()
444444
}
445445
}
446446

447-
#pragma warning disable xUnit1004 // Test methods should not be skipped
448-
[Fact(Skip = "Not relevant due to matching on template options is not implemented.")]
449-
#pragma warning restore xUnit1004 // Test methods should not be skipped
447+
[Fact]
450448
public async Task CacheSkipInvalidTemplatesTest()
451449
{
452450
string cacheLocation = TestUtils.CreateTemporaryFolder();

‎test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_InstalledPackage_OtherFeed.verified.txt

Lines changed: 31 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Microsoft.Azure.WebJobs.ItemTemplates
2-
Package version: 4.0.2738
2+
Package version: 4.0.3038
33
Details: Collection of templates for Azure Functions
44
Source Feed: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json
55
Authors:
@@ -8,30 +8,34 @@
88
License Url: https://go.microsoft.com/fwlink/?linkid=2028464
99
Repository Url: https://go.microsoft.com/fwlink/?linkid=848145
1010
Templates:
11-
Template Name Short Name Type Tags Language
12-
----------------------------------- ------------------- ---- ----------------------------------------------------- --------
13-
HttpTrigger http item Azure Function/Trigger/Http C#,F#
14-
QueueTrigger queue item Azure Function/Trigger/Storage Queue C#
15-
HttpTriggerWithOpenAPI httpOpenAPI item Azure Function/Trigger/Http C#
16-
BlobTrigger blob item Azure Function/Trigger/Blob C#,F#
17-
TimerTrigger timer item Azure Function/Trigger/Timer C#,F#
18-
DurableFunctionsOrchestration durable item Azure Function/Durable Functions Orchestration C#
19-
DurableFunctionsEntityOrchestration durableentity item Azure Function/Durable Functions Entity Orchestration C#
20-
SendGrid sendgrid item Azure Function/Ouput/SendGrid C#
21-
EventHubTrigger eventhub item Azure Function/Trigger/EventHub C#,F#
22-
ServiceBusQueueTrigger squeue item Azure Function/Trigger/Service Bus/Queue C#
23-
ServiceBusTopicTrigger stopic item Azure Function/Trigger/Service Bus/Topic C#
24-
EventGridCloudEventTrigger eventgridcloudevent item Azure Function/Trigger/EventGrid/EventGrid CloudEvent C#,F#
25-
EventGridTrigger eventgrid item Azure Function/Trigger/EventGrid C#
26-
IotHubTrigger iothub item Azure Function/Trigger/IotHub C#
27-
CosmosDBTrigger cosmos,CosmosDB item Azure Function/Trigger/Cosmos DB C#,F#
28-
SignalRTrigger signalr item Azure Function/Trigger/Http/SignalR C#
29-
RabbitMQTrigger rqueue item Azure Function/Trigger/RabbitMQ Queue C#
30-
KafkaTrigger kafka item Azure Function/Trigger/Kafka C#
31-
KafkaOutput kafkao item Azure Function/Ouput/Kafka C#
32-
SqlInputBinding sqlinput item Azure Function/Input/SQL C#
33-
SqlOutputBinding sqloutput item Azure Function/Output/SQL C#
34-
SqlTriggerBinding sqltrigger item Azure Function/Trigger/SQL C#
35-
KustoInputBinding kustoinput item Azure Function/Input/Kusto C#
36-
KustoOutputBinding kustooutput item Azure Function/Output/Kusto C#
11+
Template Name Short Name Type Tags Language
12+
----------------------------------- ---------------------------- ---- ----------------------------------------------------- --------
13+
HttpTrigger http item Azure Function/Trigger/Http C#,F#
14+
QueueTrigger queue item Azure Function/Trigger/Storage Queue C#
15+
HttpTriggerWithOpenAPI httpOpenAPI item Azure Function/Trigger/Http C#
16+
BlobTrigger blob item Azure Function/Trigger/Blob C#,F#
17+
TimerTrigger timer item Azure Function/Trigger/Timer C#,F#
18+
DurableFunctionsOrchestration durable item Azure Function/Durable Functions Orchestration C#
19+
DurableFunctionsEntityOrchestration durableentity item Azure Function/Durable Functions Entity Orchestration C#
20+
SendGrid sendgrid item Azure Function/Ouput/SendGrid C#
21+
EventHubTrigger eventhub item Azure Function/Trigger/EventHub C#,F#
22+
ServiceBusQueueTrigger squeue item Azure Function/Trigger/Service Bus/Queue C#
23+
ServiceBusTopicTrigger stopic item Azure Function/Trigger/Service Bus/Topic C#
24+
EventGridCloudEventTrigger eventgridcloudevent item Azure Function/Trigger/EventGrid/EventGrid CloudEvent C#,F#
25+
EventGridTrigger eventgrid item Azure Function/Trigger/EventGrid C#,F#
26+
IotHubTrigger iothub item Azure Function/Trigger/IotHub C#
27+
CosmosDBTrigger cosmos,CosmosDB item Azure Function/Trigger/Cosmos DB C#,F#
28+
SignalRTrigger signalr item Azure Function/Trigger/Http/SignalR C#
29+
RabbitMQTrigger rqueue item Azure Function/Trigger/RabbitMQ Queue C#
30+
KafkaTrigger kafka item Azure Function/Trigger/Kafka C#
31+
KafkaOutput kafkao item Azure Function/Ouput/Kafka C#
32+
SqlInputBinding sqlinput item Azure Function/Input/SQL C#
33+
SqlOutputBinding sqloutput item Azure Function/Output/SQL C#
34+
SqlTriggerBinding sqltrigger item Azure Function/Trigger/SQL C#
35+
KustoInputBinding kustoinput item Azure Function/Input/Kusto C#
36+
KustoOutputBinding kustooutput item Azure Function/Output/Kusto C#
37+
EventGridBlobTrigger eventgridblob item Azure Function/Trigger/Blob C#
38+
DaprServiceInvocationTrigger daprServiceInvocationTrigger item Azure Function/Trigger/Dapr C#
39+
DaprTopicTrigger daprTopicTrigger item Azure Function/Trigger/Dapr C#
40+
DaprPublishOutputBinding daprPublishOutputBinding item Azure Function/Trigger/Dapr C#
3741

‎test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_RemotePackage_OtherFeedNoVersion.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Microsoft.Azure.WebJobs.ItemTemplates
2-
Package version: 4.0.2738
2+
Package version: 4.0.3038
33
Details: Collection of templates for Azure Functions
44
Source Feed: dotnet-public [https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json]
55
Authors:

‎test/dotnet-new.Tests/DotnetNewDetailsTest.Approval.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,7 @@ public Task CanDisplayDetails_RemotePackage_OtherFeedWithVersion()
5858
return Verify(commandResult.StdOut);
5959
}
6060

61-
#pragma warning disable xUnit1004 // Test methods should not be skipped
62-
[Fact(Skip = "Test targeting specific versions")]
63-
#pragma warning restore xUnit1004 // Test methods should not be skipped
61+
[Fact]
6462
public Task CanDisplayDetails_RemotePackage_OtherFeedNoVersion()
6563
{
6664
CommandResult commandResult = new DotnetNewCommand(_log, "details", "Microsoft.Azure.WebJobs.ItemTemplates")
@@ -127,9 +125,7 @@ public Task CanDisplayDetails_InstalledPackage_NuGetFeed()
127125
return Verify(commandResult.StdOut);
128126
}
129127

130-
#pragma warning disable xUnit1004 // Test methods should not be skipped
131-
[Fact(Skip = "Test targeting specific versions")]
132-
#pragma warning restore xUnit1004 // Test methods should not be skipped
128+
[Fact]
133129
public Task CanDisplayDetails_InstalledPackage_OtherFeed()
134130
{
135131
string home = CreateTemporaryFolder(folderName: "Home");

‎test/dotnet.Tests/dotnet-msbuild/GivenMsbuildForwardingApp.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public void ItSetsMSBuildExtensionPathToExistingPath()
5050
.Exist();
5151
}
5252

53-
[Fact(Skip = "Test app base folder doesn't have Sdks")]
53+
[Fact]
5454
public void ItSetsMSBuildSDKsPathToExistingPath()
5555
{
5656
var msbuildPath = "<msbuildpath>";

0 commit comments

Comments
 (0)