Remove ToolInstallNoManifestGuide and Fix CannotFindAManifestFile

`CannotFindAManifestFile` now always provides the list of searched locations.
Remove the string that is now longer needed now that --create-manifest-if-needed is added by default.

Need to look into `ToolCommonNoManifestGuide` and if we still need that

Author: nagilson

src/Cli/dotnet/CliStrings.resx

@@ -568,8 +568,7 @@ The default is 'false.' However, when targeting .NET 7 or lower, the default is
     <value>outputpathresolver: {0} does not exist</value>
   </data>
   <data name="CannotFindAManifestFile" xml:space="preserve">
-    <value>Cannot find a manifest file.
-For a list of locations searched, specify the "-d" option before the tool name.</value>
+    <value>Cannot find a manifest file.</value>
   </data>
   <data name="CannotFindPackageIdInManifest" xml:space="preserve">
     <value>Cannot find a package with the package id {0} in the manifest file.</value>

src/Cli/dotnet/Commands/CliCommandStrings.resx

@@ -1985,10 +1985,6 @@ Tool '{1}' (version '{2}') was successfully installed.</value>
   <data name="ToolInstallManifestPathOptionName" xml:space="preserve">
     <value>PATH</value>
   </data>
-  <data name="ToolInstallNoManifestGuide" xml:space="preserve">
-    <value>If you intended to install a global tool, add `--global` to the command.
-If you would like to create a manifest, use the `--create-manifest-if-needed` flag with the `dotnet tool install` command, or use `dotnet new tool-manifest`, usually in the repo root directory.</value>
-  </data>
   <data name="ToolInstallNuGetConfigurationFileDoesNotExist" xml:space="preserve">
     <value>NuGet configuration file '{0}' does not exist.</value>
   </data>
@@ -2486,4 +2482,4 @@ To display a value, specify the corresponding command-line option without provid
   <data name="SolutionAddReferencedProjectsOptionDescription" xml:space="preserve">
     <value>Recursively add projects' ReferencedProjects to solution</value>
   </data>
-</root>
+</root>

src/Cli/dotnet/Commands/Tool/Install/ToolInstallLocalCommand.cs

@@ -194,18 +194,8 @@ public int InstallNewTool(FilePath manifestFile, PackageId packageId)
 
     public FilePath GetManifestFilePath()
     {
-        try
-        {
-            return string.IsNullOrWhiteSpace(_explicitManifestFile)
-                ? _toolManifestFinder.FindFirst(_createManifestIfNeeded)
-                : new FilePath(_explicitManifestFile);
-        }
-        catch (ToolManifestCannotBeFoundException e)
-        {
-            throw new GracefulException(
-                [e.Message, CliCommandStrings.ToolInstallNoManifestGuide],
-                verboseMessages: [e.VerboseMessage],
-                isUserError: false);
-        }
+        return string.IsNullOrWhiteSpace(_explicitManifestFile)
+            ? _toolManifestFinder.FindFirst(_createManifestIfNeeded)
+            : new FilePath(_explicitManifestFile);
     }
 }

src/Cli/dotnet/Commands/xlf/CliCommandStrings.cs.xlf

@@ -12,9 +12,4 @@ internal class ToolManifestCannotBeFoundException : GracefulException
     public ToolManifestCannotBeFoundException(string message) : base([message], null, false)
     {
     }
-
-    public ToolManifestCannotBeFoundException(string message, string optionalMessage)
-        : base([message], [optionalMessage], false)
-    {
-    }
 }

src/Cli/dotnet/ToolManifest/ToolManifestCannotBeFoundException.cs

@@ -42,9 +42,8 @@ public IReadOnlyCollection<ToolManifestPackage> Find(FilePath? filePath = null)
         if (!findAnyManifest)
         {
             throw new ToolManifestCannotBeFoundException(
-                CliStrings.CannotFindAManifestFile,
-                string.Format(CliStrings.ListOfSearched,
-                    string.Join(Environment.NewLine, allPossibleManifests.Select(f => "\t" + f.manifestfile.Value))));
+                $@"{CliStrings.CannotFindAManifestFile},
+{string.Format(CliStrings.ListOfSearched, string.Join(Environment.NewLine, allPossibleManifests.Select(f => "\t" + f.manifestfile.Value)))}");
         }
 
         return [.. toolManifestPackageAndSource.Select(t => t.toolManifestPackage)];
@@ -183,10 +182,8 @@ public FilePath FindFirst(bool createIfNotFound = false)
             }
         }
         throw new ToolManifestCannotBeFoundException(
-                CliStrings.CannotFindAManifestFile,
-                string.Format(CliStrings.ListOfSearched,
-                    string.Join(Environment.NewLine,
-                        EnumerateDefaultAllPossibleManifests().Select(f => "\t" + f.manifestfile.Value))));
+            $@"{CliStrings.CannotFindAManifestFile},
+{string.Format(CliStrings.ListOfSearched, string.Join(Environment.NewLine, EnumerateDefaultAllPossibleManifests().Select(f => "\t" + f.manifestfile.Value)))}");
     }
 
     /*
@@ -275,10 +272,8 @@ in EnumerateDefaultAllPossibleManifests())
         if (!findAnyManifest)
         {
             throw new ToolManifestCannotBeFoundException(
-                CliStrings.CannotFindAManifestFile,
-                string.Format(CliStrings.ListOfSearched,
-                    string.Join(Environment.NewLine,
-                        EnumerateDefaultAllPossibleManifests().Select(f => "\t" + f.manifestfile.Value))));
+                $@"{CliStrings.CannotFindAManifestFile}
+{string.Format(CliStrings.ListOfSearched, string.Join(Environment.NewLine, EnumerateDefaultAllPossibleManifests().Select(f => "\t" + f.manifestfile.Value)))}");
         }
 
         return result;

src/Cli/dotnet/ToolManifest/ToolManifestFinder.cs

@@ -165,9 +165,6 @@ public void GivenNoManifestFileItShouldThrowAndContainNoManifestGuide()
                 _reporter);
 
             Action a = () => toolInstallLocalCommand.Execute();
-            a.Should().Throw<GracefulException>()
-                .And.Message.Should()
-                .Contain(CliCommandStrings.ToolInstallNoManifestGuide);
 
             a.Should().Throw<GracefulException>()
                 .And.Message.Should()