Wait on task loop in case of exception (#45237)

Author: mariam-abdulla

src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs

@@ -97,38 +97,38 @@ public int Run(ParseResult parseResult)
                     if (msbuildResult != 0)
                     {
                         VSTestTrace.SafeWriteTrace(() => $"MSBuild task _GetTestsProject didn't execute properly with exit code: {msbuildResult}.");
-                        CleanUp();
                         return ExitCodes.GenericFailure;
                     }
 
                     // If not all test projects have IsTestingPlatformApplication set to true, we will simply return
                     if (!_msBuildConnectionHandler.EnqueueTestApplications())
                     {
                         VSTestTrace.SafeWriteTrace(() => LocalizableStrings.CmdUnsupportedVSTestTestApplicationsDescription);
-                        CleanUp();
                         return ExitCodes.GenericFailure;
                     }
                 }
 
                 _actionQueue.EnqueueCompleted();
                 hasFailed = _actionQueue.WaitAllActions();
-
                 // Above line will block till we have all connections and all GetTestsProject msbuild task complete.
-                _cancellationToken.Cancel();
-                _namedPipeConnectionLoop.Wait();
 
-                // Clean up everything
-                CleanUp();
+                WaitOnMSBuildHandlerPipeConnectionLoop();
             }
-            catch (Exception)
+            finally
             {
+                // Clean up everything
                 CleanUp();
-                throw;
             }
 
             return hasFailed ? ExitCodes.GenericFailure : ExitCodes.Success;
         }
 
+        private void WaitOnMSBuildHandlerPipeConnectionLoop()
+        {
+            _cancellationToken.Cancel();
+            _namedPipeConnectionLoop.Wait((int)TimeSpan.FromSeconds(30).TotalMilliseconds);
+        }
+
         private void CleanUp()
         {
             _msBuildConnectionHandler.Dispose();