Skip to content

Commit 922242b

Browse files
committed
Apply code review feedback
1 parent fac0117 commit 922242b

File tree

18 files changed

+1196
-2
lines changed

18 files changed

+1196
-2
lines changed

src/Cli/dotnet/ShellShim/ShellShimRepository.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ public void CreateShim(ToolCommand toolCommand, IReadOnlyList<FilePath> packaged
6767

6868
if (OperatingSystem.IsWindows())
6969
{
70+
// Generate a batch / .cmd file to call the executable inside the package, and forward all arguments to it.
71+
// %~dp0 expands to the directory of the batch file, so this will work regardless of the current working directory.
72+
// %* forwards all arguments passed to the batch file to the executable.
7073
string batchContent = $"@echo off\r\n\"%~dp0{relativePathToExe}\" %*\r\n";
7174
File.WriteAllText(shimPath, batchContent);
7275
}

src/Tasks/Common/Resources/Strings.resx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -987,4 +987,8 @@ You may need to build the project on another operating system or architecture, o
987987
<value>NETSDK1226: Prune Package data not found {0} {1} {2}. To ignore this error, set the AllowMissingPrunePackageData to true.</value>
988988
<comment>{StrBegins="NETSDK1226: "}</comment>
989989
</data>
990+
<data name="UnsupportedToolCommandRunner" xml:space="preserve">
991+
<value>NETSDK1227: Unsupported ToolCommandRunner value: {0}</value>
992+
<comment>{StrBegins="NETSDK1227: "}</comment>
993+
</data>
990994
</root>

src/Tasks/Common/Resources/xlf/Strings.cs.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.de.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.es.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.fr.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.it.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.ja.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.ko.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.pl.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)