Skip to content

Commit 95afe47

Browse files
committed
Set the minimum version to 17.11.0 but set the build version to 17.11.4 as what shipped in that VS version
1 parent 01bc7a1 commit 95afe47

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

eng/Versions.props

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,15 +207,17 @@
207207
208208
Some .NET Framework tasks and the resolver will need to run in a VS/MSBuild that is older
209209
than the very latest, based on what we want the SDK to support. So use a version that matches the version
210-
in minimumMSBuildVersion. In these cases, we don't want to use MicrosoftBuildVersion and other
210+
in minimumMSBuildVersion. Note that MSBuild has started versioning before release so the version we use as the Minimum should be .0
211+
to ensure we load in VS but the version we build against should be the version of MSBuild that ships in the .0 VS release.
212+
In these cases, we don't want to use MicrosoftBuildVersion and other
211213
associated properties that are updated by the VMR infrastructure. So, we read this version
212214
from the 'minimumMSBuildVersion' file in non-source-only cases into MicrosoftBuildMinimumVersion,
213215
then use that in Directory.Packages.props.
214216
215217
At usage sites, either we use MicrosoftBuildMinimumVersion, or MicrosoftBuildVersion in source-only modes. -->
216218
<MicrosoftBuildVersion>17.12.3</MicrosoftBuildVersion>
217219
<MicrosoftBuildLocalizationVersion>17.12.3-preview-24504-01</MicrosoftBuildLocalizationVersion>
218-
<MicrosoftBuildMinimumVersion Condition="Exists('$(RepoRoot)src\Layout\redist\minimumMSBuildVersion') and '$(DotNetBuildSourceOnly)' != 'true'">$([System.IO.File]::ReadAllText('$(RepoRoot)src\Layout\redist\minimumMSBuildVersion').Trim())</MicrosoftBuildMinimumVersion>
220+
<MicrosoftBuildMinimumVersion Condition="'$(DotNetBuildSourceOnly)' != 'true'">17.11.4</MicrosoftBuildMinimumVersion>
219221
</PropertyGroup>
220222
<PropertyGroup>
221223
<!-- Dependencies from https://github.com/dotnet/templating -->
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
17.11.4
1+
17.11.0

0 commit comments

Comments
 (0)