Skip to content

Commit 95bea78

Browse files
authored
Update the error for targeting net9 in 17.11 (#43143)
2 parents 080a171 + 1c7687b commit 95bea78

24 files changed

+79
-75
lines changed

eng/Versions.props

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,15 +186,17 @@
186186
187187
Some .NET Framework tasks and the resolver will need to run in a VS/MSBuild that is older
188188
than the very latest, based on what we want the SDK to support. So use a version that matches the version
189-
in minimumMSBuildVersion. In these cases, we don't want to use MicrosoftBuildVersion and other
189+
in minimumMSBuildVersion. Note that MSBuild has started versioning before release so the version we use as the Minimum should be .0
190+
to ensure we load in VS but the version we build against should be the version of MSBuild that ships in the .0 VS release.
191+
In these cases, we don't want to use MicrosoftBuildVersion and other
190192
associated properties that are updated by the VMR infrastructure. So, we read this version
191193
from the 'minimumMSBuildVersion' file in non-source-only cases into MicrosoftBuildMinimumVersion,
192194
then use that in Directory.Packages.props.
193195
194196
At usage sites, either we use MicrosoftBuildMinimumVersion, or MicrosoftBuildVersion in source-only modes. -->
195197
<MicrosoftBuildVersion>17.12.3</MicrosoftBuildVersion>
196198
<MicrosoftBuildLocalizationVersion>17.12.3-preview-24504-01</MicrosoftBuildLocalizationVersion>
197-
<MicrosoftBuildMinimumVersion Condition="Exists('$(RepoRoot)src\Layout\redist\minimumMSBuildVersion') and '$(DotNetBuildSourceOnly)' != 'true'">$([System.IO.File]::ReadAllText('$(RepoRoot)src\Layout\redist\minimumMSBuildVersion').Trim())</MicrosoftBuildMinimumVersion>
199+
<MicrosoftBuildMinimumVersion Condition="'$(DotNetBuildSourceOnly)' != 'true'">17.11.4</MicrosoftBuildMinimumVersion>
198200
</PropertyGroup>
199201
<PropertyGroup>
200202
<!-- Dependencies from https://github.com/dotnet/templating -->
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
17.8.3
1+
17.11.0

src/Tasks/Common/Resources/Strings.resx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -940,10 +940,6 @@ You may need to build the project on another operating system or architecture, o
940940
&lt;IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', '{0}'))"&gt;true&lt;/IsTrimmable&gt;</value>
941941
<comment>{StrBegin="NETSDK1212: "}</comment>
942942
</data>
943-
<data name="Net8NotCompatibleWithDev177" xml:space="preserve">
944-
<value>NETSDK1213: Targeting .NET 8.0 or higher in Visual Studio 2022 17.7 is not supported.</value>
945-
<comment>{StrBegin="NETSDK1213: "}</comment>
946-
</data>
947943
<!-- Skipping NETSDK1214 on purpose, as that is "UsingUnsupportedUseUwpFeature" on .NET 8 (see https://github.com/dotnet/sdk/issues/44006) -->
948944
<data name="TargetFrameworkIsNotRecommended" xml:space="preserve">
949945
<value>NETSDK1215: Targeting .NET Standard prior to 2.0 is no longer recommended. See {0} for more details.</value>
@@ -973,9 +969,13 @@ You may need to build the project on another operating system or architecture, o
973969
<value>NETSDK1221: NuGetPackageRoot property is empty so package Microsoft.Net.Sdk.Compilers.Toolset cannot be used but it is recommended because your MSBuild and SDK versions are mismatched. Ensure you are building with '/restore /t:Build' and not '/t:Restore;Build'.</value>
974970
<comment>{StrBegin="NETSDK1221: "}{Locked="NuGetPackageRoot"}{Locked="Microsoft.Net.Sdk.Compilers.Toolset"}{Locked="'/restore /t:Build'"}{Locked="'/t:Restore;Build'"}</comment>
975971
</data>
976-
<data name="PreferNativeArm64IgnoredForNetCoreApp" xml:space="preserve">
972+
<data name="PreferNativeArm64IgnoredForNetCoreApp" xml:space="preserve">
977973
<value>NETSDK1222: PreferNativeArm64 applies only to .NET Framework targets. It is not supported and has no effect for when targeting .NET Core.</value>
978974
<comment>{StrBegin="NETSDK1222: "}</comment>
979975
</data>
980-
<!-- The latest message added is PreferNativeArm64IgnoredForNetCoreApp. Please update this value with each PR to catch parallel PRs both adding a new message -->
976+
<data name="Net9NotCompatibleWithDev1711" xml:space="preserve">
977+
<value>NETSDK1223: Targeting .NET 9.0 or higher in Visual Studio 2022 17.11 is not supported.</value>
978+
<comment>{StrBegin="NETSDK1223: "}</comment>
979+
</data>
980+
<!-- The latest message added is Net9NotCompatibleWithDev1711. Please update this value with each PR to catch parallel PRs both adding a new message -->
981981
</root>

src/Tasks/Common/Resources/xlf/Strings.cs.xlf

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.de.xlf

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.es.xlf

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.fr.xlf

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.it.xlf

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.ja.xlf

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Common/Resources/xlf/Strings.ko.xlf

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)