Remove source build warn on diff test infra (#44569)

Author: MichaelSimons

src/SourceBuild/content/eng/pipelines/templates/jobs/sdk-diff-tests.yml

@@ -130,7 +130,6 @@ jobs:
       /p:MsftSdkTarballPath=$(MsftSdkTarballPath)
       /p:SdkTarballPath=$(SdkTarballPath)
       /p:SourceBuiltArtifactsPath=$(SourceBuiltArtifactsPath)
-      /p:SourceBuildTestsWarnOnSdkContentDiffs=false
       /p:TargetRid=${{ parameters.targetRid }}
       /p:PortableRid=$(Platform)-${{ parameters.architecture }}
     displayName: Run Tests

src/SourceBuild/content/eng/pipelines/vmr-license-scan.yml

@@ -133,7 +133,6 @@ extends:
             -flp:LogFile=$(Build.SourcesDirectory)/artifacts/logs/BuildTests_$(date +"%m%d%H%M%S").log
             -clp:v=m
             /p:SourceBuildTestsLicenseScanPath=$(repoPath)
-            /p:SourceBuildTestsWarnOnLicenseScanDiffs=false
             /p:TargetRid=linux-x64
             /p:PortableRid=linux-x64
             /p:SkipPrepareSdkArchive=true

src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/BaselineHelper.cs

@@ -45,15 +45,15 @@ public static void CompareEntries(string baselineFileName, IOrderedEnumerable<st
             Assert.Null(message);
         }
 
-        public static void CompareBaselineContents(string baselineFileName, string actualContents, ITestOutputHelper outputHelper, bool warnOnDiffs = false, string baselineSubDir = "")
+        public static void CompareBaselineContents(string baselineFileName, string actualContents, ITestOutputHelper outputHelper, string baselineSubDir = "")
         {
             string actualFilePath = Path.Combine(Config.LogsDirectory, $"Updated{baselineFileName}");
             File.WriteAllText(actualFilePath, actualContents);
 
-            CompareFiles(GetBaselineFilePath(baselineFileName, baselineSubDir), actualFilePath, outputHelper, warnOnDiffs);
+            CompareFiles(GetBaselineFilePath(baselineFileName, baselineSubDir), actualFilePath, outputHelper);
         }
 
-        public static void CompareFiles(string expectedFilePath, string actualFilePath, ITestOutputHelper outputHelper, bool warnOnDiffs = false)
+        public static void CompareFiles(string expectedFilePath, string actualFilePath, ITestOutputHelper outputHelper)
         {
             string baselineFileText = File.ReadAllText(expectedFilePath).Trim();
             string actualFileText = File.ReadAllText(actualFilePath).Trim();
@@ -64,21 +64,11 @@ public static void CompareFiles(string expectedFilePath, string actualFilePath,
             {
                 // Retrieve a diff in order to provide a UX which calls out the diffs.
                 string diff = DiffFiles(expectedFilePath, actualFilePath, outputHelper);
-                string prefix = warnOnDiffs ? "##vso[task.logissue type=warning;]" : string.Empty;
-                message = $"{Environment.NewLine}{prefix}Expected file '{expectedFilePath}' does not match actual file '{actualFilePath}`.  {Environment.NewLine}"
+                message = $"{Environment.NewLine}Expected file '{expectedFilePath}' does not match actual file '{actualFilePath}`.  {Environment.NewLine}"
                     + $"{diff}{Environment.NewLine}";
-
-                if (warnOnDiffs)
-                {
-                    outputHelper.WriteLine(message);
-                    outputHelper.WriteLine("##vso[task.complete result=SucceededWithIssues;]");
-                }
             }
 
-            if (!warnOnDiffs)
-            {
-                Assert.Null(message);
-            }
+            Assert.Null(message);
         }
 
         public static string DiffFiles(string file1Path, string file2Path, ITestOutputHelper outputHelper)

src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/Config.cs

@@ -27,8 +27,6 @@ internal static class Config
     public static string? PrereqsPath => (string)AppContext.GetData(ConfigSwitchPrefix + nameof(PrereqsPath))!;
     public static string? SdkTarballPath => (string)AppContext.GetData(ConfigSwitchPrefix + nameof(SdkTarballPath))!;
     public static string? SourceBuiltArtifactsPath => (string)AppContext.GetData(ConfigSwitchPrefix + nameof(SourceBuiltArtifactsPath))!;
-    public static bool WarnOnLicenseScanDiffs => bool.TryParse((string)AppContext.GetData(ConfigSwitchPrefix + nameof(WarnOnLicenseScanDiffs))!, out bool warnOnLicenseScanDiffs) && warnOnLicenseScanDiffs;
-    public static bool WarnOnSdkContentDiffs => bool.TryParse((string)AppContext.GetData(ConfigSwitchPrefix + nameof(WarnOnSdkContentDiffs))!, out bool warnOnSdkContentDiffs) && warnOnSdkContentDiffs;
 
     // Indicates whether the tests are being run in the context of a CI pipeline
     public static bool RunningInCI => !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("DOTNET_CI")) ||

src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/LicenseScanTests.cs

@@ -177,7 +177,7 @@ public void ScanForLicenses()
         string actualFilePath = Path.Combine(Config.LogsDirectory, $"Updated{baselineName}");
         File.WriteAllText(actualFilePath, json);
 
-        BaselineHelper.CompareFiles(expectedFilePath, actualFilePath, OutputHelper, Config.WarnOnLicenseScanDiffs);
+        BaselineHelper.CompareFiles(expectedFilePath, actualFilePath, OutputHelper);
     }
 
     private void FilterFiles(ScancodeResults scancodeResults)

src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/Microsoft.DotNet.SourceBuild.Tests.csproj

@@ -87,12 +87,6 @@
       <RuntimeHostConfigurationOption Include="$(MSBuildProjectName).SourceBuiltArtifactsPath">
         <Value>$(SourceBuiltArtifactsPath)</Value>
       </RuntimeHostConfigurationOption>
-      <RuntimeHostConfigurationOption Include="$(MSBuildProjectName).WarnOnLicenseScanDiffs">
-        <Value>$(SourceBuildTestsWarnOnLicenseScanDiffs)</Value>
-      </RuntimeHostConfigurationOption>
-      <RuntimeHostConfigurationOption Include="$(MSBuildProjectName).WarnOnSdkContentDiffs">
-        <Value>$(SourceBuildTestsWarnOnSdkContentDiffs)</Value>
-      </RuntimeHostConfigurationOption>
     </ItemGroup>
   </Target>
 

src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/README.md

@@ -16,8 +16,6 @@ Optional msbuild properties:
 - SourceBuildTestsExcludeOmniSharpTests
 - SourceBuildTestsLicenseScanPath
 - SourceBuildTestsPrereqsPath
-- SourceBuildTestsWarnOnLicenseScanDiffs
-- SourceBuildTestsWarnOnSdkContentDiffs
 
 Make sure to rebuild the test project when changing one of those values.
 

src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/SdkContentTests.cs

@@ -48,7 +48,7 @@ public void CompareMsftToSbFileList()
 
         string diff = BaselineHelper.DiffFiles(msftFileListingFileName, sbFileListingFileName, OutputHelper);
         diff = RemoveDiffMarkers(diff);
-        BaselineHelper.CompareBaselineContents("MsftToSbSdkFiles.diff", diff, OutputHelper, Config.WarnOnSdkContentDiffs, BaselineSubDir);
+        BaselineHelper.CompareBaselineContents("MsftToSbSdkFiles.diff", diff, OutputHelper, BaselineSubDir);
     }
 
     [ConditionalFact(typeof(SdkContentTests), nameof(IncludeSdkContentTests))]
@@ -79,7 +79,7 @@ public void CompareMsftToSbAssemblyVersions()
 
             string diff = BaselineHelper.DiffFiles(MsftVersionsFileName, SbVersionsFileName, OutputHelper);
             diff = RemoveDiffMarkers(diff);
-            BaselineHelper.CompareBaselineContents("MsftToSbSdkAssemblyVersions.diff", diff, OutputHelper, Config.WarnOnSdkContentDiffs, BaselineSubDir);
+            BaselineHelper.CompareBaselineContents("MsftToSbSdkAssemblyVersions.diff", diff, OutputHelper, BaselineSubDir);
         }
         finally
         {