Skip to content

Commit b78f6ef

Browse files
authored
make dicts in NamedPipeBase strong typed (#49984)
1 parent 289afaf commit b78f6ef

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/Cli/dotnet/Commands/Test/IPC/NamedPipeBase.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ namespace Microsoft.DotNet.Cli.Commands.Test.IPC;
1414

1515
internal abstract class NamedPipeBase
1616
{
17-
private readonly Dictionary<Type, object> _typeSerializer = [];
18-
private readonly Dictionary<int, object> _idSerializer = [];
17+
private readonly Dictionary<Type, INamedPipeSerializer> _typeSerializer = [];
18+
private readonly Dictionary<int, INamedPipeSerializer> _idSerializer = [];
1919

2020
public void RegisterSerializer(INamedPipeSerializer namedPipeSerializer, Type type)
2121
{
@@ -25,9 +25,9 @@ public void RegisterSerializer(INamedPipeSerializer namedPipeSerializer, Type ty
2525

2626
protected INamedPipeSerializer GetSerializer(int id, bool skipUnknownMessages = false)
2727
{
28-
if (_idSerializer.TryGetValue(id, out object serializer))
28+
if (_idSerializer.TryGetValue(id, out INamedPipeSerializer serializer))
2929
{
30-
return (INamedPipeSerializer)serializer;
30+
return serializer;
3131
}
3232
else
3333
{
@@ -46,8 +46,8 @@ protected INamedPipeSerializer GetSerializer(int id, bool skipUnknownMessages =
4646

4747

4848
protected INamedPipeSerializer GetSerializer(Type type)
49-
=> _typeSerializer.TryGetValue(type, out object serializer)
50-
? (INamedPipeSerializer)serializer
49+
=> _typeSerializer.TryGetValue(type, out INamedPipeSerializer serializer)
50+
? serializer
5151
: throw new ArgumentException(string.Format(
5252
CultureInfo.InvariantCulture,
5353
#if dotnet

0 commit comments

Comments
 (0)