Skip to content

Commit bc5d218

Browse files
Copilotbaronfel
authored andcommitted
Add tool-specific package identity descriptions to replace generic examples
Co-authored-by: baronfel <[email protected]>
1 parent 00f9c9f commit bc5d218

16 files changed

+77
-1
lines changed

src/Cli/dotnet/CliStrings.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -819,6 +819,9 @@ The default is 'false.' However, when targeting .NET 7 or lower, the default is
819819
<data name="PackageIdentityArgumentDescription" xml:space="preserve">
820820
<value>Package reference in the form of a package identifier like 'Newtonsoft.Json' or package identifier and version separated by '@' like '[email protected]'.</value>
821821
</data>
822+
<data name="ToolPackageIdentityArgumentDescription" xml:space="preserve">
823+
<value>Package reference in the form of a package identifier like 'dotnetsay' or package identifier and version separated by '@' like '[email protected]'.</value>
824+
</data>
822825
<data name="PackageIdentityArgumentIdOrVersionIsNull" xml:space="preserve">
823826
<value>Package reference id and version must not be null.</value>
824827
</data>

src/Cli/dotnet/Commands/Tool/Install/ToolInstallCommandParser.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Microsoft.DotNet.Cli.Commands.Tool.Install;
1010

1111
internal static class ToolInstallCommandParser
1212
{
13-
public static readonly Argument<PackageIdentityWithRange> PackageIdentityArgument = CommonArguments.RequiredPackageIdentityArgument();
13+
public static readonly Argument<PackageIdentityWithRange> PackageIdentityArgument = CommonArguments.RequiredToolPackageIdentityArgument();
1414

1515
public static readonly Option<string> VersionOption = new("--version")
1616
{

src/Cli/dotnet/CommonArguments.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,14 @@ public static DynamicArgument<PackageIdentityWithRange> RequiredPackageIdentityA
2727
Arity = ArgumentArity.ExactlyOne,
2828
};
2929

30+
public static DynamicArgument<PackageIdentityWithRange> RequiredToolPackageIdentityArgument() =>
31+
new("packageId")
32+
{
33+
Description = CliStrings.ToolPackageIdentityArgumentDescription,
34+
CustomParser = (ArgumentResult argumentResult) => ParsePackageIdentityWithVersionSeparator(argumentResult.Tokens[0]?.Value)!.Value,
35+
Arity = ArgumentArity.ExactlyOne,
36+
};
37+
3038
private static PackageIdentityWithRange? ParsePackageIdentityWithVersionSeparator(string? packageIdentity, char versionSeparator = '@')
3139
{
3240
if (string.IsNullOrEmpty(packageIdentity))

src/Cli/dotnet/xlf/CliStrings.cs.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/xlf/CliStrings.de.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/xlf/CliStrings.es.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/xlf/CliStrings.fr.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/xlf/CliStrings.it.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/xlf/CliStrings.ja.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/xlf/CliStrings.ko.xlf

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)