Skip to content

Commit c30463d

Browse files
committed
Disable tests when running on 17.11 or newer as this set of tests targets net9 and checks for the warning we spit out
1 parent 36ed9ca commit c30463d

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

test/Microsoft.NET.Build.Tests/GivenThatWeManifestSupportedFrameworks.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public GivenThatWeManifestSupportedFrameworks(ITestOutputHelper log) : base(log)
99
{
1010
}
1111

12-
[RequiresMSBuildVersionTheory("17.8.0")]
12+
[RequiresMSBuildVersionTheory("17.12.0")]
1313
[InlineData(".NETCoreApp")]
1414
[InlineData(".NETStandard")]
1515
public void TheMaximumVersionsAreSupported(string targetFrameworkIdentifier)

test/Microsoft.NET.Build.Tests/GivenThatWeWantToFloatWarningLevels.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ static void Main()
375375
[InlineData("recommended", "true", new string[] { "CA1310", "CA1068", "CA2200" })]
376376
[InlineData("all", "false", new string[] { "CA1031", "CA1310", "CA1068", "CA2200" })]
377377
[InlineData("all", "true", new string[] { "CA1031", "CA1310", "CA1068", "CA2200" })]
378-
[RequiresMSBuildVersionTheory("17.8.0")]
378+
[RequiresMSBuildVersionTheory("17.12.0")]
379379
public void It_bulk_configures_rules_with_different_analysis_modes(string analysisMode, string codeAnalysisTreatWarningsAsErrors, string[] expectedViolations)
380380
{
381381
var testProject = new TestProject

test/Microsoft.NET.Build.Tests/SourceLinkTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public void WithNoGitMetadata()
112112
/// <summary>
113113
/// When creating a new repository locally we want the build to work and not report warnings even before the remote is set.
114114
/// </summary>
115-
[RequiresMSBuildVersionFact("17.8.0")]
115+
[RequiresMSBuildVersionFact("17.12.0")]
116116
public void WithNoRemoteNoCommit()
117117
{
118118
var testAsset = _testAssetsManager
@@ -131,7 +131,7 @@ public void WithNoRemoteNoCommit()
131131
/// <summary>
132132
/// When creating a new repository locally we want the build to work and not report warnings even before the remote is set.
133133
/// </summary>
134-
[RequiresMSBuildVersionFact("17.8.0")]
134+
[RequiresMSBuildVersionFact("17.12.0")]
135135
public void WithNoRemote()
136136
{
137137
var testAsset = _testAssetsManager

test/Microsoft.NET.Clean.Tests/GivenThatWeWantToCleanAProject.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public GivenThatWeWantToCleanAHelloWorldProject(ITestOutputHelper log) : base(lo
1212
{
1313
}
1414

15-
[RequiresMSBuildVersionFact("17.8.0")]
15+
[RequiresMSBuildVersionFact("17.12.0")]
1616
public void It_cleans_without_logging_assets_message()
1717
{
1818
var testAsset = _testAssetsManager

test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public GivenThatWeWantToPublishAnAotApp(ITestOutputHelper log) : base(log)
1919
{
2020
}
2121

22-
[RequiresMSBuildVersionTheory("17.8.0")]
22+
[RequiresMSBuildVersionTheory("17.12.0")]
2323
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
2424
public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled(string targetFramework)
2525
{
@@ -73,7 +73,7 @@ public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled(string
7373
.And.HaveStdOutContaining("Hello World");
7474
}
7575

76-
[RequiresMSBuildVersionTheory("17.8.0")]
76+
[RequiresMSBuildVersionTheory("17.12.0")]
7777
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
7878
public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_false(string targetFramework)
7979
{

0 commit comments

Comments
 (0)