Fix exception handling in mock package downloader

dsplaisted · dsplaisted · commit cde3627e5736 · 2025-06-11T15:39:09.000-04:00
diff --git a/test/Microsoft.DotNet.Tools.Tests.ComponentMocks/MockNuGetPackageDownloader.cs b/test/Microsoft.DotNet.Tools.Tests.ComponentMocks/MockNuGetPackageDownloader.cs
@@ -129,10 +129,9 @@ public Task<NuGetVersion> GetLatestPackageVersion(PackageId packageId, PackageSo
             return Task.FromResult(_packageVersions.Max());
         }
 
-        public Task<NuGetVersion> GetBestPackageVersionAsync(PackageId packageId, VersionRange versionRange, PackageSourceLocation packageSourceLocation = null)
+        public async Task<NuGetVersion> GetBestPackageVersionAsync(PackageId packageId, VersionRange versionRange, PackageSourceLocation packageSourceLocation = null)
         {
-            return GetBestPackageVersionAndSourceAsync(packageId, versionRange, packageSourceLocation)
-                .ContinueWith(t => t.Result.version, TaskContinuationOptions.OnlyOnRanToCompletion);
+            return (await GetBestPackageVersionAndSourceAsync(packageId, versionRange, packageSourceLocation)).version;
         }
 
         public Task<(NuGetVersion version, PackageSource source)> GetBestPackageVersionAndSourceAsync(PackageId packageId,

Original file line number	Diff line number	Diff line change
`@@ -129,10 +129,9 @@ public Task<NuGetVersion> GetLatestPackageVersion(PackageId packageId, PackageSo`
`129`	`129`	`return Task.FromResult(_packageVersions.Max());`
`130`	`130`	`}`
`131`	`131`
`132`		`- public Task<NuGetVersion> GetBestPackageVersionAsync(PackageId packageId, VersionRange versionRange, PackageSourceLocation packageSourceLocation = null)`
	`132`	`+ public async Task<NuGetVersion> GetBestPackageVersionAsync(PackageId packageId, VersionRange versionRange, PackageSourceLocation packageSourceLocation = null)`
`133`	`133`	`{`
`134`		`- return GetBestPackageVersionAndSourceAsync(packageId, versionRange, packageSourceLocation)`
`135`		`- .ContinueWith(t => t.Result.version, TaskContinuationOptions.OnlyOnRanToCompletion);`
	`134`	`+ return (await GetBestPackageVersionAndSourceAsync(packageId, versionRange, packageSourceLocation)).version;`
`136`	`135`	`}`
`137`	`136`
`138`	`137`	`public Task<(NuGetVersion version, PackageSource source)> GetBestPackageVersionAndSourceAsync(PackageId packageId,`