Handle extension members by 'make member static' (#7739)

* Handle extension members by 'make member static'

* Suppress warning introduced by Roslyn bump

* Suppress warning in test

* Update tests

* Update Roslyn

To bring in dotnet/roslyn#79571.

* Update Roslyn

To bring in dotnet/roslyn#79576.

Author: jjonescz

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers/Microsoft.CodeQuality.Analyzers/QualityGuidelines/MarkMembersAsStatic.cs

@@ -130,6 +130,11 @@ void OnOperationBlockStart(OperationBlockStartAnalysisContext context)
                             // This member cannot be made static.
                             isInstanceReferenced = true;
                         }
+                        else if (operation.Parameter.ContainingSymbol is ITypeSymbol { TypeKind: ITypeSymbolExtensions.ExtensionTypeKind })
+                        {
+                            // We're referencing an extension receiver.
+                            isInstanceReferenced = true;
+                        }
                     }, OperationKind.ParameterReference);
 
                     context.RegisterOperationBlockEndAction(context =>

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Utilities/Compiler/Extensions/ITypeSymbolExtensions.cs

@@ -12,6 +12,8 @@ namespace Analyzer.Utilities.Extensions
 {
     internal static class ITypeSymbolExtensions
     {
+        public const TypeKind ExtensionTypeKind = (TypeKind)14;
+
 #if CODEANALYSIS_V3_OR_BETTER
         public static bool IsAssignableTo(
             [NotNullWhen(returnValue: true)] this ITypeSymbol? fromSymbol,

src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DefineAccessorsForAttributeArgumentsTests.Fixer.cs

@@ -153,7 +153,6 @@ public InternalGetterTestAttribute(string name)
     public string Name
     {
         get { return m_name; }
-
         internal set { m_name = value; }
     }
 }");
@@ -198,7 +197,6 @@ public InternalGetterTestAttribute(string name)
     public string Name
     {
         get { return m_name; }
-
         internal set { m_name = value; }
     }
 }");
@@ -285,7 +283,6 @@ public PublicSetterTestAttribute(string name)
     public string Name
     {
         get { return m_name; }
-
         internal set { m_name = value; }
     }
 }");

src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/ImplementStandardExceptionConstructorsTests.Fixer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the MIT license.  See License.txt in the project root for license information.
+// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the MIT license.  See License.txt in the project root for license information.
 
 using System.Threading.Tasks;
 using Xunit;

src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/OperatorOverloadsHaveNamedAlternatesTests.Fixer.cs

@@ -206,7 +206,6 @@ public class C
 public class C
 {
     public static C operator +(C left, C right) { return new C(); }
-
     public static C Add(C left, C right) { return new C(); }
 }
 ",
@@ -235,7 +234,6 @@ public class C
 {
     public static bool operator true(C item) { return true; }
     public static bool operator false(C item) { return false; }
-
     public bool IsTrue => true;
 }
 ",

src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/OperatorsShouldHaveSymmetricalOverloadsTests.Fixer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the MIT license.  See License.txt in the project root for license information.
+// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the MIT license.  See License.txt in the project root for license information.
 
 using System.Threading.Tasks;
 using Xunit;

src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/OverrideEqualsAndOperatorEqualsOnValueTypesTests.Fixer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the MIT license.  See License.txt in the project root for license information.
+// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the MIT license.  See License.txt in the project root for license information.
 
 using System.Threading.Tasks;
 using Xunit;

src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.CodeQuality.Analyzers/QualityGuidelines/MarkMembersAsStaticTests.cs

@@ -1322,7 +1322,7 @@ public string P3
         get;
     }
 
-    public string [|P4|] // Because of the error there is no generated field
+    public string P4 // Because of the error there is no generated field
     {
         [DebuggerStepThrough]
         {|CS8051:set|};
@@ -1500,7 +1500,7 @@ public static void Recursive(string argument)
             }.RunAsync();
         }
 
-        [Fact(Skip = "Need update of roslyn to parse primary constructors properly"), WorkItem(6573, "https://github.com/dotnet/roslyn-analyzers/issues/6573")]
+        [Fact, WorkItem(6573, "https://github.com/dotnet/roslyn-analyzers/issues/6573")]
         public Task PrimaryConstructor()
         {
             return new VerifyCS.Test
@@ -1529,5 +1529,53 @@ public class Student(int id, string name, IEnumerable<decimal> grades)
                 LanguageVersion = LanguageVersion.Preview
             }.RunAsync();
         }
+
+        [Fact, WorkItem(78858, "https://github.com/dotnet/roslyn/issues/78858")]
+        public Task ExtensionMembers_Instance()
+        {
+            return new VerifyCS.Test
+            {
+                TestCode = """
+                    public static class E
+                    {
+                        extension(int x)
+                        {
+                            public int M() => x + 1;
+                            public int P => x + 1;
+                        }
+                    }
+                    """,
+                LanguageVersion = LanguageVersion.Preview,
+            }.RunAsync();
+        }
+
+        [Fact, WorkItem(78858, "https://github.com/dotnet/roslyn/issues/78858")]
+        public Task ExtensionMembers_Static()
+        {
+            return new VerifyCS.Test
+            {
+                TestCode = """
+                    public static class E
+                    {
+                        extension(int x)
+                        {
+                            public int [|M|]() => 1;
+                            public int [|P|] => 2;
+                        }
+                    }
+                    """,
+                FixedCode = """
+                    public static class E
+                    {
+                        extension(int x)
+                        {
+                            public static int M() => 1;
+                            public static int P => 2;
+                        }
+                    }
+                    """,
+                LanguageVersion = LanguageVersion.Preview,
+            }.RunAsync();
+        }
     }
 }

src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.NetCore.Analyzers/InteropServices/DynamicInterfaceCastableImplementationTests.cs

@@ -586,8 +586,7 @@ interface I2 : I
 {
     void I.Method() {}
 
-    private static void Method2(I2 @this)
-    { }
+    private static void Method2(I2 @this) { }
 }";
 
             await VerifyCSCodeFixAsync(source, codeFix);
@@ -787,8 +786,7 @@ interface I2 : I
 {
     void I.Method() {}
 
-    public static void Method2(I2 @this)
-    { }
+    public static void Method2(I2 @this) { }
 }";
 
             await VerifyCSCodeFixAsync(source, codeFix);
@@ -826,8 +824,7 @@ interface I2 : I
 {
     void I.Method() {}
 
-    public static void Method2(I2 @this)
-    { }
+    public static void Method2(I2 @this) { }
 }";
 
             await VerifyCSCodeFixAsync(source, codeFix);
@@ -865,8 +862,7 @@ interface I2 : I
 {
     void I.Method() {}
 
-    protected static void Method2(I2 @this)
-    { }
+    protected static void Method2(I2 @this) { }
 }";
 
             await VerifyCSCodeFixAsync(source, codeFix);