address comments

Author: Surayya Huseyn Zada

src/Containers/Microsoft.NET.Build.Containers/DigestUtils.cs

@@ -21,7 +21,7 @@ internal static string GetShaFromDigest(string digest)
     {
         if (!digest.StartsWith("sha256:", StringComparison.OrdinalIgnoreCase))
         {
-            throw new ArgumentException("Invalid digest format. Digest must start with 'sha256:'.");
+            throw new ArgumentException($"Invalid digest '{digest}'. Digest must start with 'sha256:'.");
         }
 
         return digest.Substring("sha256:".Length);

src/Containers/Microsoft.NET.Build.Containers/ImageIndexGenerator.cs

@@ -13,7 +13,7 @@ internal static class ImageIndexGenerator
     /// <summary>
     /// Generates an image index from the given images.
     /// </summary>
-    /// <param name="images"></param>
+    /// <param name="images">Images to generate image index from.</param>
     /// <returns>Returns json string of image index and image index mediaType.</returns>
     /// <exception cref="ArgumentException"></exception>
     /// <exception cref="NotSupportedException"></exception>
@@ -45,6 +45,15 @@ internal static (string, string) GenerateImageIndex(BuiltImage[] images)
         }
     }
 
+    /// <summary>
+    /// Generates an image index from the given images.
+    /// </summary>
+    /// <param name="images">Images to generate image index from.</param>
+    /// <param name="manifestMediaType">Media type of the manifest.</param>
+    /// <param name="imageIndexMediaType">Media type of the produced image index.</param>
+    /// <returns>Returns json string of image index and image index mediaType.</returns>
+    /// <exception cref="ArgumentException"></exception>
+    /// <exception cref="NotSupportedException"></exception>
     internal static string GenerateImageIndex(BuiltImage[] images, string manifestMediaType, string imageIndexMediaType)
     {
         if (images.Length == 0)
@@ -116,6 +125,7 @@ private static string GetJsonStringFromImageIndex<T>(T imageIndex)
         {
             DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull
         };
+        // To avoid things like \u002B for '+' especially in media types ("application/vnd.oci.image.manifest.v1\u002Bjson"), we use UnsafeRelaxedJsonEscaping.
         var escapeOptions = new JsonSerializerOptions
         {
             Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping

src/Containers/Microsoft.NET.Build.Containers/LocalDaemons/ArchiveFileRegistry.cs

@@ -23,7 +23,7 @@ internal async Task LoadAsync<T>(T image, SourceImageReference sourceReference,
         var directorySeparatorChar = Path.DirectorySeparatorChar;
 
         // if doesn't end with a file extension, assume it's a directory
-        if (!fullPath.Split(directorySeparatorChar).Last().Contains('.'))
+        if (!Path.HasExtension(fullPath))
         {
            fullPath += Path.DirectorySeparatorChar;
         }

src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateImageIndex.cs

@@ -23,7 +23,7 @@ public void Dispose()
         _cancellationTokenSource.Dispose();
     }
 
-    private bool IsLocalPull => string.IsNullOrEmpty(BaseRegistry.Trim());
+    private bool IsLocalPull => string.IsNullOrWhiteSpace(BaseRegistry);
 
     public override bool Execute()
     {

src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs

@@ -23,7 +23,7 @@ public sealed partial class CreateNewImage : Microsoft.Build.Utilities.Task, ICa
     /// </summary>
     public string ToolPath { get; set; }
 
-    private bool IsLocalPull => string.IsNullOrEmpty(BaseRegistry.Trim());
+    private bool IsLocalPull => string.IsNullOrWhiteSpace(BaseRegistry);
 
     public void Cancel() => _cancellationTokenSource.Cancel();