Skip to content

Commit eb25d4f

Browse files
committed
Merge branch 'nohwnd-patch-1' of https://github.com/dotnet/sdk into nohwnd-patch-1
2 parents 50d3b55 + 0b0e820 commit eb25d4f

File tree

22 files changed

+139
-129
lines changed

22 files changed

+139
-129
lines changed

eng/Version.Details.xml

Lines changed: 76 additions & 76 deletions
Large diffs are not rendered by default.

eng/Versions.props

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
</PropertyGroup>
8484
<PropertyGroup>
8585
<!-- Dependency from https://github.com/dotnet/winforms -->
86-
<MicrosoftDotnetWinFormsProjectTemplatesPackageVersion>10.0.0-alpha.1.25054.1</MicrosoftDotnetWinFormsProjectTemplatesPackageVersion>
86+
<MicrosoftDotnetWinFormsProjectTemplatesPackageVersion>10.0.0-alpha.1.25056.6</MicrosoftDotnetWinFormsProjectTemplatesPackageVersion>
8787
</PropertyGroup>
8888
<PropertyGroup>
8989
<!-- Dependencies from https://github.com/dotnet/runtime -->
@@ -136,24 +136,24 @@
136136
</PropertyGroup>
137137
<PropertyGroup>
138138
<!-- Dependencies from https://github.com/dotnet/windowsdesktop -->
139-
<VSRedistCommonWindowsDesktopSharedFrameworkx64100PackageVersion>10.0.0-alpha.1.25056.2</VSRedistCommonWindowsDesktopSharedFrameworkx64100PackageVersion>
140-
<MicrosoftWindowsDesktopAppRuntimewinx64PackageVersion>10.0.0-alpha.1.25056.2</MicrosoftWindowsDesktopAppRuntimewinx64PackageVersion>
141-
<MicrosoftWindowsDesktopAppRefPackageVersion>10.0.0-alpha.1.25056.2</MicrosoftWindowsDesktopAppRefPackageVersion>
139+
<VSRedistCommonWindowsDesktopSharedFrameworkx64100PackageVersion>10.0.0-alpha.1.25057.15</VSRedistCommonWindowsDesktopSharedFrameworkx64100PackageVersion>
140+
<MicrosoftWindowsDesktopAppRuntimewinx64PackageVersion>10.0.0-alpha.1.25057.15</MicrosoftWindowsDesktopAppRuntimewinx64PackageVersion>
141+
<MicrosoftWindowsDesktopAppRefPackageVersion>10.0.0-alpha.1.25057.15</MicrosoftWindowsDesktopAppRefPackageVersion>
142142
</PropertyGroup>
143143
<PropertyGroup>
144144
<!-- Dependencies from https://github.com/nuget/nuget.client -->
145-
<NuGetBuildTasksPackageVersion>6.13.0-rc.108</NuGetBuildTasksPackageVersion>
146-
<NuGetBuildTasksConsolePackageVersion>6.13.0-rc.108</NuGetBuildTasksConsolePackageVersion>
147-
<NuGetLocalizationPackageVersion>6.13.0-rc.108</NuGetLocalizationPackageVersion>
148-
<NuGetBuildTasksPackPackageVersion>6.13.0-rc.108</NuGetBuildTasksPackPackageVersion>
149-
<NuGetCommandLineXPlatPackageVersion>6.13.0-rc.108</NuGetCommandLineXPlatPackageVersion>
150-
<NuGetProjectModelPackageVersion>6.13.0-rc.108</NuGetProjectModelPackageVersion>
151-
<MicrosoftBuildNuGetSdkResolverPackageVersion>6.13.0-rc.108</MicrosoftBuildNuGetSdkResolverPackageVersion>
152-
<NuGetCommonPackageVersion>6.13.0-rc.108</NuGetCommonPackageVersion>
153-
<NuGetConfigurationPackageVersion>6.13.0-rc.108</NuGetConfigurationPackageVersion>
154-
<NuGetFrameworksPackageVersion>6.13.0-rc.108</NuGetFrameworksPackageVersion>
155-
<NuGetPackagingPackageVersion>6.13.0-rc.108</NuGetPackagingPackageVersion>
156-
<NuGetVersioningPackageVersion>6.13.0-rc.108</NuGetVersioningPackageVersion>
145+
<NuGetBuildTasksPackageVersion>6.13.0-rc.111</NuGetBuildTasksPackageVersion>
146+
<NuGetBuildTasksConsolePackageVersion>6.13.0-rc.111</NuGetBuildTasksConsolePackageVersion>
147+
<NuGetLocalizationPackageVersion>6.13.0-rc.111</NuGetLocalizationPackageVersion>
148+
<NuGetBuildTasksPackPackageVersion>6.13.0-rc.111</NuGetBuildTasksPackPackageVersion>
149+
<NuGetCommandLineXPlatPackageVersion>6.13.0-rc.111</NuGetCommandLineXPlatPackageVersion>
150+
<NuGetProjectModelPackageVersion>6.13.0-rc.111</NuGetProjectModelPackageVersion>
151+
<MicrosoftBuildNuGetSdkResolverPackageVersion>6.13.0-rc.111</MicrosoftBuildNuGetSdkResolverPackageVersion>
152+
<NuGetCommonPackageVersion>6.13.0-rc.111</NuGetCommonPackageVersion>
153+
<NuGetConfigurationPackageVersion>6.13.0-rc.111</NuGetConfigurationPackageVersion>
154+
<NuGetFrameworksPackageVersion>6.13.0-rc.111</NuGetFrameworksPackageVersion>
155+
<NuGetPackagingPackageVersion>6.13.0-rc.111</NuGetPackagingPackageVersion>
156+
<NuGetVersioningPackageVersion>6.13.0-rc.111</NuGetVersioningPackageVersion>
157157
</PropertyGroup>
158158
<PropertyGroup>
159159
<!-- Dependencies from https://github.com/Microsoft/vstest -->
@@ -192,13 +192,13 @@
192192
</PropertyGroup>
193193
<PropertyGroup>
194194
<!-- Dependencies from https://github.com/dotnet/templating -->
195-
<MicrosoftTemplateEngineAbstractionsPackageVersion>10.0.100-alpha.1.25055.1</MicrosoftTemplateEngineAbstractionsPackageVersion>
195+
<MicrosoftTemplateEngineAbstractionsPackageVersion>10.0.100-alpha.1.25057.1</MicrosoftTemplateEngineAbstractionsPackageVersion>
196196
<MicrosoftTemplateEngineEdgePackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineEdgePackageVersion>
197197
<MicrosoftTemplateEngineOrchestratorRunnableProjectsPackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineOrchestratorRunnableProjectsPackageVersion>
198198
<MicrosoftTemplateEngineUtilsPackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineUtilsPackageVersion>
199199
<MicrosoftTemplateSearchCommonPackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateSearchCommonPackageVersion>
200200
<!-- test dependencies -->
201-
<MicrosoftTemplateEngineMocksPackageVersion>10.0.100-alpha.1.25055.1</MicrosoftTemplateEngineMocksPackageVersion>
201+
<MicrosoftTemplateEngineMocksPackageVersion>10.0.100-alpha.1.25057.1</MicrosoftTemplateEngineMocksPackageVersion>
202202
<MicrosoftTemplateEngineTestHelperPackageVersion>$(MicrosoftTemplateEngineMocksPackageVersion)</MicrosoftTemplateEngineTestHelperPackageVersion>
203203
<MicrosoftTemplateEngineAuthoringTemplateVerifierVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineAuthoringTemplateVerifierVersion>
204204
<MicrosoftTemplateSearchTemplateDiscoveryPackageVersion>$(MicrosoftTemplateEngineMocksPackageVersion)</MicrosoftTemplateSearchTemplateDiscoveryPackageVersion>
@@ -236,14 +236,14 @@
236236
</PropertyGroup>
237237
<PropertyGroup>
238238
<!-- Dependencies from https://github.com/dotnet/razor -->
239-
<MicrosoftAspNetCoreMvcRazorExtensionsToolingInternalPackageVersion>9.0.0-preview.25056.3</MicrosoftAspNetCoreMvcRazorExtensionsToolingInternalPackageVersion>
240-
<MicrosoftCodeAnalysisRazorToolingInternalVersion>9.0.0-preview.25056.3</MicrosoftCodeAnalysisRazorToolingInternalVersion>
241-
<MicrosoftNETSdkRazorSourceGeneratorsTransportPackageVersion>9.0.0-preview.25056.3</MicrosoftNETSdkRazorSourceGeneratorsTransportPackageVersion>
239+
<MicrosoftAspNetCoreMvcRazorExtensionsToolingInternalPackageVersion>9.0.0-preview.25056.4</MicrosoftAspNetCoreMvcRazorExtensionsToolingInternalPackageVersion>
240+
<MicrosoftCodeAnalysisRazorToolingInternalVersion>9.0.0-preview.25056.4</MicrosoftCodeAnalysisRazorToolingInternalVersion>
241+
<MicrosoftNETSdkRazorSourceGeneratorsTransportPackageVersion>9.0.0-preview.25056.4</MicrosoftNETSdkRazorSourceGeneratorsTransportPackageVersion>
242242
</PropertyGroup>
243243
<PropertyGroup>
244244
<!-- Dependencies from https://github.com/dotnet/wpf -->
245-
<MicrosoftNETSdkWindowsDesktopPackageVersion>10.0.0-alpha.1.25056.3</MicrosoftNETSdkWindowsDesktopPackageVersion>
246-
<MicrosoftDotNetWpfProjectTemplatesPackageVersion>10.0.0-alpha.1.25056.3</MicrosoftDotNetWpfProjectTemplatesPackageVersion>
245+
<MicrosoftNETSdkWindowsDesktopPackageVersion>10.0.0-alpha.1.25057.4</MicrosoftNETSdkWindowsDesktopPackageVersion>
246+
<MicrosoftDotNetWpfProjectTemplatesPackageVersion>10.0.0-alpha.1.25057.4</MicrosoftDotNetWpfProjectTemplatesPackageVersion>
247247
</PropertyGroup>
248248
<PropertyGroup Label="Template versions">
249249
<!-- 10.0 Template versions -->
@@ -269,12 +269,12 @@
269269
</PropertyGroup>
270270
<PropertyGroup>
271271
<!-- Dependencies from https://github.com/dotnet/sourcelink -->
272-
<MicrosoftBuildTasksGitVersion>9.0.0-beta.24631.1</MicrosoftBuildTasksGitVersion>
273-
<MicrosoftSourceLinkCommonVersion>9.0.0-beta.24631.1</MicrosoftSourceLinkCommonVersion>
274-
<MicrosoftSourceLinkAzureReposGitVersion>9.0.0-beta.24631.1</MicrosoftSourceLinkAzureReposGitVersion>
275-
<MicrosoftSourceLinkGitHubVersion>9.0.0-beta.24631.1</MicrosoftSourceLinkGitHubVersion>
276-
<MicrosoftSourceLinkGitLabVersion>9.0.0-beta.24631.1</MicrosoftSourceLinkGitLabVersion>
277-
<MicrosoftSourceLinkBitbucketGitVersion>9.0.0-beta.24631.1</MicrosoftSourceLinkBitbucketGitVersion>
272+
<MicrosoftBuildTasksGitVersion>9.0.0-beta.25057.2</MicrosoftBuildTasksGitVersion>
273+
<MicrosoftSourceLinkCommonVersion>9.0.0-beta.25057.2</MicrosoftSourceLinkCommonVersion>
274+
<MicrosoftSourceLinkAzureReposGitVersion>9.0.0-beta.25057.2</MicrosoftSourceLinkAzureReposGitVersion>
275+
<MicrosoftSourceLinkGitHubVersion>9.0.0-beta.25057.2</MicrosoftSourceLinkGitHubVersion>
276+
<MicrosoftSourceLinkGitLabVersion>9.0.0-beta.25057.2</MicrosoftSourceLinkGitLabVersion>
277+
<MicrosoftSourceLinkBitbucketGitVersion>9.0.0-beta.25057.2</MicrosoftSourceLinkBitbucketGitVersion>
278278
</PropertyGroup>
279279
<!-- Get .NET Framework reference assemblies from NuGet packages -->
280280
<PropertyGroup>

exclusion.dic

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
awaiter
22
crossgen
3+
csharp
34
cshtml
45
deserializer
56
msbuild
67
nuget
78
nupkg
89
nuspec
10+
roslyn
911
sdk
1012
sdks
1113
tfm

src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/ApiCompatServiceProvider.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ public ApiCompatServiceProvider(Func<ISuppressionEngine, ISuppressibleLog> logFa
3232

3333
// The attribute data symbol filter is a composite that contains both the accessibility
3434
// symbol filter and the doc id symbol filter.
35-
CompositeSymbolFilter attributeDataSymbolFilter = new CompositeSymbolFilter()
36-
.Add(accessibilitySymbolFilter);
35+
CompositeSymbolFilter attributeDataSymbolFilter = new(accessibilitySymbolFilter);
3736
if (excludeAttributesFiles is not null)
3837
{
3938
attributeDataSymbolFilter.Add(new DocIdSymbolFilter(excludeAttributesFiles));

src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/RegexStringTransformer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ internal class RegexStringTransformer
1919
/// <param name="replacementString">The replacement string that contains the capture group markers (i.e. $1).</param>
2020

2121
public RegexStringTransformer(string captureGroupPattern, string replacementString)
22-
: this(new (string, string)[] { (captureGroupPattern, replacementString) })
22+
: this([(captureGroupPattern, replacementString)])
2323
{
2424
}
2525

src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/RoslynResolver.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ public void Unregister()
6464
private Assembly? LoadRoslyn(AssemblyName name, Func<string, Assembly> loadFromPath)
6565
{
6666
const string codeAnalysisName = "Microsoft.CodeAnalysis";
67-
const string codeAnalysisCsharpName = "Microsoft.CodeAnalysis.CSharp";
67+
const string codeAnalysisCSharpName = "Microsoft.CodeAnalysis.CSharp";
6868

69-
if (name.Name == codeAnalysisName || name.Name == codeAnalysisCsharpName)
69+
if (name.Name == codeAnalysisName || name.Name == codeAnalysisCSharpName)
7070
{
7171
Assembly asm = loadFromPath(Path.Combine(_roslynAssembliesPath!, $"{name.Name}.dll"));
7272
Version? resolvedVersion = asm.GetName().Version;
@@ -78,7 +78,7 @@ public void Unregister()
7878
// Being extra defensive but we want to avoid that we accidentally load two different versions of either
7979
// of the roslyn assemblies from a different location, so let's load them both on the first request.
8080
if (name.Name == codeAnalysisName)
81-
loadFromPath(Path.Combine(_roslynAssembliesPath!, $"{codeAnalysisCsharpName}.dll"));
81+
loadFromPath(Path.Combine(_roslynAssembliesPath!, $"{codeAnalysisCSharpName}.dll"));
8282
else
8383
loadFromPath(Path.Combine(_roslynAssembliesPath!, $"{codeAnalysisName}.dll"));
8484

src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/ValidateAssemblies.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ private static IEnumerable<string> GetFilesFromPath(string path)
165165
}
166166
}
167167

168-
return new string[] { path };
168+
return [path];
169169
}
170170
}
171171
}

src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Task/Microsoft.DotNet.ApiCompat.Task.csproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@
3434
<ItemGroup>
3535
<PackageReference Include="Microsoft.Build.Framework" ExcludeAssets="Runtime" />
3636
<PackageReference Include="Microsoft.Build.Utilities.Core" ExcludeAssets="Runtime" />
37-
<ProjectReference Include="..\Microsoft.DotNet.PackageValidation\Microsoft.DotNet.PackageValidation.csproj" />
38-
<ProjectReference Include="..\Microsoft.DotNet.ApiCompatibility\Microsoft.DotNet.ApiCompatibility.csproj" />
3937
<!-- We carry NuGet as part of the package in case the package is used with an older SDKs or with full framework MSBuild. -->
4038
<PackageReference Include="NuGet.Packaging" PrivateAssets="All" Publish="true" />
4139
<!-- The ApiCompatibility/PackageValidation stuff depends on CodeAnalysis.CSharp at the version that is
@@ -47,6 +45,9 @@
4745
it should never share types with this assembly. Within this task, the RoslynResolver should provide a good
4846
closure of references. -->
4947
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" ExcludeAssets="Runtime" PrivateAssets="all" />
48+
49+
<ProjectReference Include="..\Microsoft.DotNet.PackageValidation\Microsoft.DotNet.PackageValidation.csproj" />
50+
<ProjectReference Include="..\Microsoft.DotNet.ApiCompatibility\Microsoft.DotNet.ApiCompatibility.csproj" />
5051
</ItemGroup>
5152

5253
<ItemGroup>

src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Tool/Microsoft.DotNet.ApiCompat.Tool.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<IsShippingPackage>true</IsShippingPackage>
88
<PackAsTool>true</PackAsTool>
99
<ToolCommandName>apicompat</ToolCommandName>
10+
<RollForward>Major</RollForward>
1011
<PackageDescription>Tool to perform api compatibility checks on assemblies and packages.</PackageDescription>
1112
</PropertyGroup>
1213

src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Logging/SuppressionEngine.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class SuppressionEngine(string? noWarn = null, bool baselineAllErrors = f
1717
protected const string DiagnosticIdDocumentationComment = " https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids ";
1818
private readonly HashSet<Suppression> _baselineSuppressions = [];
1919
private readonly HashSet<Suppression> _suppressions = [];
20-
private readonly HashSet<string> _noWarn = string.IsNullOrEmpty(noWarn) ? [] : new HashSet<string>(noWarn!.Split(';'));
20+
private readonly HashSet<string> _noWarn = string.IsNullOrEmpty(noWarn) ? [] : new(noWarn!.Split(';'));
2121

2222
/// <inheritdoc/>
2323
public bool BaselineAllErrors { get; } = baselineAllErrors;

0 commit comments

Comments
 (0)