Skip to content

Commit ed9379d

Browse files
Forgindgithub-actions
authored andcommitted
string.Empty --> null
1 parent 5557f47 commit ed9379d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Cli/dotnet/commands/dotnet-workload/WorkloadUtilities.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ internal static int VersionCompare(string first, string second)
2828
return comparison;
2929
}
3030

31-
var modifiedFirst = new ReleaseVersion(1, 1, 1, firstDash == first.Length ? string.Empty : first.Substring(firstDash));
32-
var modifiedSecond = new ReleaseVersion(1, 1, 1, secondDash == second.Length ? string.Empty : second.Substring(secondDash));
31+
var modifiedFirst = new ReleaseVersion(1, 1, 1, firstDash == first.Length ? null : first.Substring(firstDash));
32+
var modifiedSecond = new ReleaseVersion(1, 1, 1, secondDash == second.Length ? null : second.Substring(secondDash));
3333

3434
return modifiedFirst.CompareTo(modifiedSecond);
3535
}

src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,8 @@ private static int VersionCompare(string first, string second)
230230
return comparison;
231231
}
232232

233-
var modifiedFirst = new ReleaseVersion(1, 1, 1, firstDash == first.Length ? string.Empty : first.Substring(firstDash));
234-
var modifiedSecond = new ReleaseVersion(1, 1, 1, secondDash == second.Length ? string.Empty : second.Substring(secondDash));
233+
var modifiedFirst = new ReleaseVersion(1, 1, 1, firstDash == first.Length ? null : first.Substring(firstDash));
234+
var modifiedSecond = new ReleaseVersion(1, 1, 1, secondDash == second.Length ? null : second.Substring(secondDash));
235235

236236
return modifiedFirst.CompareTo(modifiedSecond);
237237
}

0 commit comments

Comments
 (0)