Skip to content

Commit ef306ab

Browse files
authored
Pass official build id props via /p: (#43520)
1 parent c2257cb commit ef306ab

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

src/SourceBuild/content/repo-projects/Directory.Build.props

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<RunEachTargetSeparately Condition="'$(BuildInParallel)' == 'true' and '$(ContinuousIntegrationBuild)' != 'true'">true</RunEachTargetSeparately>
1414
</PropertyGroup>
1515

16-
<Import Project="$(GitInfoRepoPropsFile)" Condition="Exists('$(GitInfoRepoPropsFile)')" />
16+
<Import Project="$(GitInfoRepoPropsFile)" Condition="Exists('$(GitInfoRepoPropsFile)') and '$(UseOfficialBuildVersioning)' != 'false'" />
1717

1818
<PropertyGroup>
1919
<!-- Fake, to satisfy the SDK. -->
@@ -87,6 +87,7 @@
8787
<!-- Pass locations for assets -->
8888
<BuildArgs>$(BuildArgs) /p:SourceBuiltAssetsDir=$(ArtifactsAssetsDir)</BuildArgs>
8989
<BuildArgs>$(BuildArgs) /p:SourceBuiltAssetManifestsDir=$(RepoAssetManifestsDir)</BuildArgs>
90+
<BuildArgs Condition="'$(OfficialBuildId)' != ''">$(BuildArgs) /p:OfficialBuildId=$(OfficialBuildId)</BuildArgs>
9091
</PropertyGroup>
9192

9293
<PropertyGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'">
@@ -144,19 +145,6 @@
144145

145146
</ItemGroup>
146147

147-
<!--
148-
Apply official build versioning to match Microsoft build. These are based on build date, so
149-
need to be parsed from Maestro++ auto-update and passed through.
150-
-->
151-
<ItemGroup Condition="'$(UseOfficialBuildVersioning)' != 'false'">
152-
<EnvironmentVariables Include="OfficialBuildId=$(OfficialBuildId)" />
153-
<EnvironmentVariables Include="BUILD_BUILDNUMBER=$(OfficialBuildId)" />
154-
155-
<EnvironmentVariables Include="DotNetUseShippingVersions=true" />
156-
<EnvironmentVariables Include="PreReleaseVersionLabel=$(PreReleaseVersionLabel)" />
157-
<EnvironmentVariables Include="PackageVersionStamp=$(PreReleaseVersionLabel)" />
158-
</ItemGroup>
159-
160148
<ItemGroup>
161149
<EnvironmentVariables Include="DeterministicSourcePaths=true" Condition="'$(DeterministicBuildOptOut)' != 'true'" />
162150
<EnvironmentVariables Include="DeterministicSourcePaths=false" Condition="'$(DeterministicBuildOptOut)' == 'true'" />

0 commit comments

Comments
 (0)