Skip to content

Commit f38ab24

Browse files
author
Mirroring
committed
Merge commit 'a85c17a62d70f53dbb16cbd5967621b3c898e647'
2 parents d0cb993 + a85c17a commit f38ab24

File tree

5 files changed

+44
-10
lines changed

5 files changed

+44
-10
lines changed

NuGet.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<add key="darc-int-dotnet-runtime-89ef51c" value="https://pkgs.dev.azure.com/dnceng/internal/_packaging/darc-int-dotnet-runtime-89ef51c5/nuget/v3/index.json" />
3131
<!-- End: Package sources from dotnet-runtime -->
3232
<!-- Begin: Package sources from dotnet-templating -->
33+
<add key="darc-pub-dotnet-templating-7d36300" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-templating-7d36300e/nuget/v3/index.json" />
3334
<add key="darc-pub-dotnet-templating-b8edc79" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-templating-b8edc791/nuget/v3/index.json" />
3435
<add key="darc-pub-dotnet-templating-b8edc79-3" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-templating-b8edc791-3/nuget/v3/index.json" />
3536
<add key="darc-pub-dotnet-templating-b8edc79-2" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-templating-b8edc791-2/nuget/v3/index.json" />

eng/Version.Details.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Dependencies>
33
<ProductDependencies>
4-
<Dependency Name="Microsoft.TemplateEngine.Abstractions" Version="8.0.405">
4+
<Dependency Name="Microsoft.TemplateEngine.Abstractions" Version="8.0.406">
55
<Uri>https://github.com/dotnet/templating</Uri>
6-
<Sha>b8edc79137b4beddbee6c98794638fa0110b40df</Sha>
6+
<Sha>7d36300e8f8e564c786fd76a49c4c4e99abf1fb2</Sha>
77
</Dependency>
8-
<Dependency Name="Microsoft.TemplateEngine.Mocks" Version="8.0.405-servicing.24575.2">
8+
<Dependency Name="Microsoft.TemplateEngine.Mocks" Version="8.0.406-servicing.25057.5">
99
<Uri>https://github.com/dotnet/templating</Uri>
10-
<Sha>b8edc79137b4beddbee6c98794638fa0110b40df</Sha>
10+
<Sha>7d36300e8f8e564c786fd76a49c4c4e99abf1fb2</Sha>
1111
</Dependency>
12-
<Dependency Name="Microsoft.SourceBuild.Intermediate.templating" Version="8.0.405-servicing.24575.2">
12+
<Dependency Name="Microsoft.SourceBuild.Intermediate.templating" Version="8.0.406-servicing.25057.5">
1313
<Uri>https://github.com/dotnet/templating</Uri>
14-
<Sha>b8edc79137b4beddbee6c98794638fa0110b40df</Sha>
14+
<Sha>7d36300e8f8e564c786fd76a49c4c4e99abf1fb2</Sha>
1515
<SourceBuild RepoName="templating" ManagedOnly="true" />
1616
</Dependency>
1717
<Dependency Name="Microsoft.NETCore.App.Ref" Version="8.0.12">

eng/Versions.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,13 @@
141141
</PropertyGroup>
142142
<PropertyGroup>
143143
<!-- Dependencies from https://github.com/dotnet/templating -->
144-
<MicrosoftTemplateEngineAbstractionsPackageVersion>8.0.405</MicrosoftTemplateEngineAbstractionsPackageVersion>
144+
<MicrosoftTemplateEngineAbstractionsPackageVersion>8.0.406</MicrosoftTemplateEngineAbstractionsPackageVersion>
145145
<MicrosoftTemplateEngineEdgePackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineEdgePackageVersion>
146146
<MicrosoftTemplateEngineOrchestratorRunnableProjectsPackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineOrchestratorRunnableProjectsPackageVersion>
147147
<MicrosoftTemplateEngineUtilsPackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineUtilsPackageVersion>
148148
<MicrosoftTemplateSearchCommonPackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateSearchCommonPackageVersion>
149149
<!-- test dependencies -->
150-
<MicrosoftTemplateEngineMocksPackageVersion>8.0.405-servicing.24575.2</MicrosoftTemplateEngineMocksPackageVersion>
150+
<MicrosoftTemplateEngineMocksPackageVersion>8.0.406-servicing.25057.5</MicrosoftTemplateEngineMocksPackageVersion>
151151
<MicrosoftTemplateEngineTestHelperPackageVersion>$(MicrosoftTemplateEngineMocksPackageVersion)</MicrosoftTemplateEngineTestHelperPackageVersion>
152152
<MicrosoftTemplateEngineAuthoringTemplateVerifierVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineAuthoringTemplateVerifierVersion>
153153
<MicrosoftTemplateSearchTemplateDiscoveryPackageVersion>$(MicrosoftTemplateEngineMocksPackageVersion)</MicrosoftTemplateSearchTemplateDiscoveryPackageVersion>

src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@
110110

111111
<ItemGroup Label="AppCommand Assignment" Condition="'$(ContainerAppCommandInstruction)' != 'None'">
112112
<!-- For self-contained, invoke the native executable as a single arg -->
113-
<ContainerAppCommand Condition="@(ContainerAppCommand->Count()) == 0 and '$(UseAppHost)' == 'true' and !$(_ContainerIsTargetingWindows)" Include="$(ContainerWorkingDirectory)/$(AssemblyName)" />
114-
<ContainerAppCommand Condition="@(ContainerAppCommand->Count()) == 0 and '$(UseAppHost)' == 'true' and $(_ContainerIsTargetingWindows)" Include="$(AssemblyName)$(_NativeExecutableExtension)" />
113+
<ContainerAppCommand Condition="@(ContainerAppCommand->Count()) == 0 and '$(_ContainerIsSelfContained)' == 'true' and !$(_ContainerIsTargetingWindows)" Include="$(ContainerWorkingDirectory)/$(AssemblyName)" />
114+
<ContainerAppCommand Condition="@(ContainerAppCommand->Count()) == 0 and '$(_ContainerIsSelfContained)' == 'true' and $(_ContainerIsTargetingWindows)" Include="$(AssemblyName)$(_NativeExecutableExtension)" />
115115
<!-- For non self-contained, invoke `dotnet` `app.dll` as separate args -->
116116
<ContainerAppCommand Condition="@(ContainerAppCommand->Count()) == 0" Include="dotnet;$(TargetFileName)" />
117117
</ItemGroup>

src/Tests/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -688,6 +688,39 @@ public void EndToEnd_NoAPI_Console()
688688
privateNuGetAssets.Delete(true);
689689
}
690690

691+
[DockerAvailableFact]
692+
public void EndToEnd_SingleArch_NoRid()
693+
{
694+
// Create a new console project
695+
DirectoryInfo newProjectDir = CreateNewProject("console");
696+
697+
string imageName = NewImageName();
698+
string imageTag = "1.0";
699+
700+
// Run PublishContainer for multi-arch
701+
CommandResult commandResult = new DotnetCommand(
702+
_testOutput,
703+
"publish",
704+
"/t:PublishContainer",
705+
$"/p:ContainerBaseImage={DockerRegistryManager.FullyQualifiedBaseImageAspNet}",
706+
$"/p:ContainerRepository={imageName}",
707+
$"/p:ContainerImageTag={imageTag}",
708+
"/p:EnableSdkContainerSupport=true")
709+
.WithWorkingDirectory(newProjectDir.FullName)
710+
.Execute();
711+
commandResult.Should().Pass();
712+
713+
// Check that the containers can be run
714+
CommandResult processResultX64 = ContainerCli.RunCommand(
715+
_testOutput,
716+
"--rm",
717+
"--name",
718+
$"test-container-singlearch-norid",
719+
$"{imageName}:{imageTag}")
720+
.Execute();
721+
processResultX64.Should().Pass().And.HaveStdOut("Hello, World!");
722+
}
723+
691724
[DockerSupportsArchFact("linux/arm64")]
692725
public void EndToEndMultiArch_LocalRegistry()
693726
{

0 commit comments

Comments
 (0)