Skip to content

Commit fa406ce

Browse files
authored
Merge branch 'main' into darc-main-df148418-dc42-4fd5-b2b0-1748e6e2663f
2 parents 883a2e9 + 564081f commit fa406ce

File tree

5 files changed

+16
-11
lines changed

5 files changed

+16
-11
lines changed

CODEOWNERS

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# This is a comment.
22
# Each line is a file pattern followed by one or more owners.
3+
# Syntax: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax
34

45
# These owners will be the default owners for everything in
56
# the repo. Unless a later match takes precedence,
@@ -100,14 +101,20 @@
100101
/test/Microsoft.DotNet.GenAPI/ @dotnet/area-infrastructure-libraries
101102
/test/Microsoft.DotNet.ApiSymbolExtensions.Tests/ @dotnet/area-infrastructure-libraries
102103

103-
# Area: dotnet containers
104+
# Area-Containers
104105
/src/Cli/Containers @dotnet/sdk-container-builds-maintainers
105106
/test/containerize.UnitTests @dotnet/sdk-container-builds-maintainers
106107
/test/Microsoft.NET.Build.Containers.IntegrationTests @dotnet/sdk-container-builds-maintainers
107108
/test/Microsoft.NET.Build.Containers.UnitTests @dotnet/sdk-container-builds-maintainers
108109

109-
# dotnet-format
110+
# Area-Format
110111
/src/BuiltInTools/dotnet-format @dotnet/roslyn-ide
111112
/test/dotnet-format.UnitTests @dotnet/roslyn-ide
112113

113-
/src/Microsoft.CodeAnalysis.NetAnalyzers @dotnet/dotnet-analyzers
114+
# Area-Microsoft.CodeAnalysis.NetAnalyzers
115+
/src/Microsoft.CodeAnalysis.NetAnalyzers @dotnet/dotnet-analyzers
116+
117+
# Area-Infrastructure
118+
.vsts-ci.yml @MiYanni
119+
.vsts-pr.yml @MiYanni
120+
/eng/pipelines @MiYanni

src/Layout/redist/targets/GeneratePackagePruneData.targets

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,12 @@
3030
</MSBuild>
3131
</Target>
3232

33-
<!-- TODO: Remove conditions from UsingTask and target when a new SDK with the CollatePackageDownload task built-in is consumed. -->
34-
<UsingTask TaskName="Microsoft.NET.Build.Tasks.CollatePackageDownloads" AssemblyFile="$(MicrosoftNETBuildTasksAssembly)" Condition="'$(MaxNetVersion)' != '$(TargetingPackPruneVersion)'" />
33+
<UsingTask TaskName="Microsoft.NET.Build.Tasks.CollatePackageDownloads" AssemblyFile="$(MicrosoftNETBuildTasksAssembly)" />
3534
<Target Name="AddTargetingPacksForPruneDataAsPackageDownloads"
3635
BeforeTargets="CollectPackageDownloads"
37-
DependsOnTargets="GetTargetingPacksForPruneData"
38-
Condition="'$(MaxNetVersion)' != '$(TargetingPackPruneVersion)'">
39-
<CollatePackageDownloads Packages="@(TargetingPackForPruneData->Metadata('PackageName'))">
36+
DependsOnTargets="GetTargetingPacksForPruneData">
37+
<CollatePackageDownloads Packages="@(TargetingPackForPruneData->Metadata('PackageName'))"
38+
Condition="'@(TargetingPackForPruneData)' != ''">
4039
<Output TaskParameter="PackageDownloads" ItemName="PackageDownload" />
4140
</CollatePackageDownloads>
4241
</Target>

src/Tasks/sdk-tasks/sdk-tasks.InTree.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
<UsingTask TaskName="AddMetadataIsPE" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1414
<UsingTask TaskName="CalculateTemplateVersions" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1515
<UsingTask TaskName="ChangeEntryPointLibraryName" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
16-
<UsingTask TaskName="CollatePackageDownloads" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1716
<UsingTask TaskName="Crossgen" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1817
<UsingTask TaskName="ExtractArchiveToDirectory" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1918
<UsingTask TaskName="GenerateDefaultRuntimeFrameworkVersion" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />

template_feed/Microsoft.DotNet.Common.ItemTemplates/content/EditorConfig/Dotnet/.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ indent_style = space
99
indent_size = 2
1010

1111
# Xml project files
12-
[*.{csproj,fsproj,vbproj,proj}]
12+
[*.{csproj,fsproj,vbproj,proj,slnx}]
1313
indent_size = 2
1414

1515
# Xml config files

test/dotnet-new.IntegrationTests/Approvals/AllCommonItemsCreate.-o#EditorConfig-file#-n#item.verified/EditorConfig-file/.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ indent_style = space
99
indent_size = 2
1010

1111
# Xml project files
12-
[*.{csproj,fsproj,vbproj,proj}]
12+
[*.{csproj,fsproj,vbproj,proj,slnx}]
1313
indent_size = 2
1414

1515
# Xml config files

0 commit comments

Comments
 (0)