extract error messages into Strings

Author: Surayya Huseyn Zada

src/Containers/Microsoft.NET.Build.Containers/ImagePublisher.cs

@@ -73,7 +73,7 @@ await PushToLocalRegistryAsync(
                     telemetry,
                     cancellationToken,
                     destinationImageReference.LocalRegistry!.LoadAsync,
-                    logWarningForMultiArch : true).ConfigureAwait(false);
+                    logTipAboutContainerd : true).ConfigureAwait(false);
                 break;
             case DestinationImageReferenceKind.RemoteRegistry:
                 await PushToRemoteRegistryAsync(
@@ -111,7 +111,7 @@ private static async Task PushToLocalRegistryAsync<T>(
         Telemetry telemetry,
         CancellationToken cancellationToken,
         Func<T, SourceImageReference, DestinationImageReference, CancellationToken, Task> loadFunc,
-        bool logWarningForMultiArch = false)
+        bool logTipAboutContainerd = false)
     {
         ILocalRegistry localRegistry = destinationImageReference.LocalRegistry!;
         if (!(await localRegistry.IsAvailableAsync(cancellationToken).ConfigureAwait(false)))
@@ -148,9 +148,9 @@ private static async Task PushToLocalRegistryAsync<T>(
         {
             telemetry.LogLocalLoadError();
             Log.LogErrorFromException(dle, showStackTrace: false);
-            if (logWarningForMultiArch && dle.Message.Contains("no such file or directory"))
+            if (logTipAboutContainerd && dle.Message.Contains("no such file or directory"))
             {
-                Log.LogMessage(MessageImportance.High, "Tip: For multi-arch image publishing, ensude that 'Use containerd for pulling and storing images' is checked in Docker Desktop settings.");
+                Log.LogMessage(MessageImportance.High, Strings.TipToEnableContainerdForMultiArch);
             }
         }
     }

src/Containers/Microsoft.NET.Build.Containers/Resources/Strings.Designer.cs

@@ -366,7 +366,7 @@
     </comment>
   </data>
   <data name="MixedMediaTypes" xml:space="preserve">
-    <value>'mediaType' of manifests should be the same in manifest list (image index).</value>
+    <value>'mediaType' of manifests should be the same in image index.</value>
     <comment/>
   </data>
   <data name="UnsupportedMediaType" xml:space="preserve">
@@ -382,13 +382,29 @@
     <comment/>
   </data>
   <data name="InvalidImageManifest" xml:space="preserve">
-    <value>Cannot create image index because at least one of the provided images manifest is invalid.</value>
+    <value>Cannot create image index because at least one of the provided images' manifest is invalid.</value>
+    <comment/>
+  </data>
+  <data name="InvalidImageConfig" xml:space="preserve">
+    <value>Cannot create image index because at least one of the provided images' config is invalid.</value>
+    <comment/>
+  </data>
+  <data name="ImageConfigMissingArchitecture" xml:space="preserve">
+    <value>Cannot create image index because at least one of the provided images' config is missing 'architecture'.</value>
+    <comment/>
+  </data>
+  <data name="ImageConfigMissingOs" xml:space="preserve">
+    <value>Cannot create image index because at least one of the provided images' config is missing 'os'.</value>
     <comment/>
   </data>
   <data name="ImageIndex_PodmanNotSupported" xml:space="preserve">
     <value>Image index creation for Podman is not supported.</value>
     <comment/>
   </data>
+  <data name="TipToEnableContainerdForMultiArch" xml:space="preserve">
+    <value>Tip: For multi-arch image publishing, ensude that 'Use containerd for pulling and storing images' is checked in Docker Desktop settings.</value>
+    <comment/>
+  </data>
   <data name="LocalDocker_FailedToGetConfig" xml:space="preserve">
     <value>Error while reading daemon config: {0}</value>
     <comment>{0} is the exception message that ends with period</comment>