Skip to content

Fully model the --binaryLogger MSBuild option in the CLI command parsers so that watch doesn't have to do custom handling #49989

@tmat

Description

@tmat

The list of options command.Options.Where(o => o is IForwardedOption) does not include -bl msbuild option, while it does include --property msbuild option:

Image

dotnet watch needs to forward this option to dotnet build instead of forwarding it to the application.

We should:

  • check the documentation for MSBuild's binlog option
  • create a structure to hold the data encoded in the argument
  • add a field to the MSBuildArgs struct for holding all MSBuild args
  • Create a System.CommandLine option for the -bl arg and apply it to all Commands that forward to MSBuild today
  • add the parsing of this field via the new option to the MSBuildArgs parsing function
  • make sure that the MSBuildForwardingApp forwards the '-bl' argument when calling actual MSbuild.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions