Open
Conversation
github-actions
bot
added
the
Area-Containers
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the net472 target and associated packaging/test/layout infrastructure from the Containers SDK (Microsoft.NET.Build.Containers), aligning with the move away from Full Framework MSBuild for VS container operations.
Changes:
- Drop multi-targeting (
$(SdkTargetFramework);net472) forMicrosoft.NET.Build.Containersand related integration tests, removingnet472-only source/test shims. - Remove
net472task publishing/packaging outputs (layout + nupkg content) and update package content expectations accordingly. - Update the shipped
.propsto always point at the .NET (net10.0) task implementation.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/UnitTests.proj | Stops including Containers integration tests in the TestFullMSBuild/net472 run. |
| test/Microsoft.NET.Build.Containers.IntegrationTests/PackageTests.cs | Updates dependency and nupkg content assertions to remove tasks/net472 expectations. |
| test/Microsoft.NET.Build.Containers.IntegrationTests/Microsoft.NET.Build.Containers.IntegrationTests.csproj | Removes net472 target and related conditional compilation setup. |
| test/Microsoft.NET.Build.Containers.IntegrationTests/FullFramework/CreateNewImageToolTaskTests.cs | Deletes Full Framework–specific tests for the removed ToolTask-based implementation. |
| src/Layout/redist/targets/GenerateLayout.targets | Removes publishing of net472 task assets into the redist layout. |
| src/Layout/redist/targets/Crossgen.targets | Updates comment to reflect removal of net472 components. |
| src/Containers/packaging/package.csproj | Removes net472 packaging path and dependency harvesting for net472 tasks. |
| src/Containers/packaging/build/Microsoft.NET.Build.Containers.props | Removes MSBuild runtime-based TFM selection; uses only net10.0 tasks and updates UsingTask declarations. |
| src/Containers/Microsoft.NET.Build.Containers/net472Definitions.cs | Deletes net472-only polyfills (IsExternalInit, NotNullWhenAttribute). |
| src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImageToolTask.cs | Deletes the net472 ToolTask-based shim implementation. |
| src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageAndTag.cs | Removes now-unused NETFRAMEWORK-only using directives. |
| src/Containers/Microsoft.NET.Build.Containers/PublicAPI/net472/PublicAPI.Unshipped.txt | Removes net472 public API baseline. |
| src/Containers/Microsoft.NET.Build.Containers/PublicAPI/net472/PublicAPI.Shipped.txt | Removes net472 public API baseline header. |
| src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj | Removes net472 TFM and all net472-specific compile/package reference conditionals. |
| src/Containers/Microsoft.NET.Build.Containers/ContainerHelpers.cs | Removes NETFRAMEWORK/NET conditional usings now that net472 is gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
net472target from the Containers SDK (Microsoft.NET.Build.Containers), keeping only the .NET Core ($(SdkTargetFramework)) target.The
net472build existed to support Visual Studio's Full-Framework MSBuild (MSBuildRuntimeType == Full). Now that VS uses .NET Runtime with HostObject support for container operations, thenet472target and all this infrastructure is no longer needed.Fixes
dotnet/msbuild#11333