Ignore internal .NET Framework assemblies in AssemblySymbolLoader #46059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves the false positive warnings in dotnet/aspnetcore#59853
ghost
added
ViktorHofer
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Jan 16, 2025
The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK.
carlossanlop
approved these changes
Jan 16, 2025
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
One minor comment, otherwise LGTM.
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/AssemblySymbolLoader.cs
Outdated
Show resolved
Hide resolved
| public class AssemblySymbolLoader : IAssemblySymbolLoader | ||
| { | ||
| // This is a list of dangling .NET Framework internal assemblies that should never get loaded. | ||
| private static readonly HashSet<string> s_assembliesToIgnore = [ |
Contributor
There was a problem hiding this comment.
How did you obtain this list?
Member
Author
There was a problem hiding this comment.
Eric gave me the list but the tool and the command that generated is C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.8>\tools\verifyClosure\verifyClosure.exe .\
ericstj
approved these changes
Jan 16, 2025
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
LGTM - just a couple minor suggestions.
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/AssemblySymbolLoader.cs
Show resolved
Hide resolved
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/AssemblySymbolLoader.cs
Outdated
Show resolved
Hide resolved
…ySymbolLoader.cs Co-authored-by: Eric StJohn <[email protected]>
Member
Author
|
Unrelated but the hardcoded ".dll" extension in
This isn't a problem with Package Validation as only |
3 tasks
wtgodbe
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Jan 17, 2025
* Update .NET SDK Update .NET SDK to version 10.0.100-alpha.1.25063.8. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Suppress CP1002 temporarily via NoWarn The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK. * Remove NoWarns completely * Update SDK and dotnet tool versions * Update SDK and tools version in global.json * NoWarn CP1002 for MessagePack project --------- Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <[email protected]>
captainsafia
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 11, 2025
* Update .NET SDK Update .NET SDK to version 10.0.100-alpha.1.25063.8. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Suppress CP1002 temporarily via NoWarn The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK. * Remove NoWarns completely * Update SDK and dotnet tool versions * Update SDK and tools version in global.json * NoWarn CP1002 for MessagePack project --------- Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the false positive warnings in dotnet/aspnetcore#59853