Clean up the dotnet --info workloads messaging to be more consistent and localizable #50068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prior WorkloadManifestInstallationConfigurationWorkloadSets message. Clean up the prior message as it was combinging works in a way that's challenging for translators. Allow loose manifests to be translated but not workload sets.
There was a problem hiding this comment.
Pull Request Overview
This PR improves the localization and messaging consistency for dotnet --info workload configuration. The changes split a generic parameterized message into two specific messages and update the corresponding source strings to better support translation workflows.
- Split the generic "WorkloadManifestInstallationConfiguration" message into separate messages for workload sets and loose manifests
- Updated the "ShouldInstallAWorkloadSet" message to be more direct and clear
- Modified the code to use the new specific message strings instead of string formatting
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CliCommandStrings.resx | Replaced parameterized message with two specific messages and updated workload set installation message |
| WorkloadCommandParser.cs | Updated code to use specific message strings instead of string formatting |
| Multiple .xlf files | Updated localization files with new message keys and marked translations for review |
Open
3 tasks
dsplaisted
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the ShouldInstallAWorkloadSet message to better fit with the prior WorkloadManifestInstallationConfigurationWorkloadSets message.
Clean up the prior message as it was combinging works in a way that's challenging for translators.
Allow loose manifests to be translated but not workload sets.