Skip to content

[wasm] Don't call .NET runtime if browser refresh script for HotReload is missing #50138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

[wasm] Don't call .NET runtime if browser refresh script for HotReload is missing #50138

merged 1 commit into from
Aug 11, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 8, 2025 •
edited
Loading

The scenario that happens is:

  • Application is published in debug, meaning the HotReload package is referenced
  • Since it's publish, ILLink will remove all un-referenced assemblies
  • Running the publish output results in calling JSExport that has been ILLinked out

To mitigate it, we don't call JSExport when browser refresh script is not used

Related to dotnet/runtime#118442

@maraf maraf added this to the 10.0.1xx milestone Aug 8, 2025
@maraf maraf self-assigned this Aug 8, 2025
@maraf maraf added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Aug 8, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @@maraf.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@maraf maraf marked this pull request as ready for review August 11, 2025 12:24
@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 12:24
Copilot
Copilot AI reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a runtime error that occurs when a WebAssembly application is published in debug mode with HotReload packages referenced, but ILLink removes unreferenced assemblies during publishing, causing JSExport calls to fail.

  • Introduces a guard condition to prevent calling JSExport methods when the browser refresh script is not present
  • Adds early return in onRuntimeReady when HotReload is not enabled to avoid assembly export calls

@maraf
Copy link
Member Author

maraf commented Aug 11, 2025

cc @tmat

@maraf maraf merged commit 35c6ce5 into dotnet:main Aug 11, 2025
30 checks passed
@maraf maraf deleted the maraf/WasmHotReloadPublishDebug branch August 11, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tmat tmat tmat approved these changes

@javiercn javiercn javiercn approved these changes

Assignees

@maraf maraf

Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Milestone
10.0.1xx
Development

Successfully merging this pull request may close these issues.
3 participants
@maraf @tmat @javiercn