Skip to content

Remove dnx.ps1 #51120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/10.0.1xx
Choose a base branch
from
Open

Remove dnx.ps1 #51120

wants to merge 1 commit into from
+0 −9

Conversation

dsplaisted
Copy link
Member

@dsplaisted dsplaisted commented Oct 3, 2025 •
edited
Loading

See #51067. The .ps1 script prevents the CLI from correctly processing --. So we'll remove the script, This will regress to the "terminate batch job" behavior described in #49623, but that's better than incorrectly processing command line arguments.

Description

Removes dnx.ps1 helper script.

Customer impact

Fixes processing of -- when calling dnx from PowerShell.
Brings back "Terminate Batch Job" prompt when CTRL+C is pressed, but this is preferrable to incorrectly processing the command line.

Regression

dnx is new in .NET 10. This was a regression from a previous preview release.

Risk

Low

@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

/ba-g GenerateBundle known issue

@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

This LGTM but we need to get Tactics approval

@build-analysis build-analysis bot mentioned this pull request Oct 3, 2025
Open
@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

@dotnet/dotnet-docker-admin this PR would remove the dnx.ps1 file due to negative user impacts - it looks like this file is part of the Windows containers - how much work is it to clean it up there?

@lbussell
Copy link
Contributor

lbussell commented Oct 3, 2025 •
edited
Loading

@dotnet/dotnet-docker-admin this PR would remove the dnx.ps1 file due to negative user impacts - it looks like this file is part of the Windows containers - how much work is it to clean it up there?

It's easy to remove it. dotnet-docker's PR validation should fail whenever the change flows in, at which point we can just revert the change.

@rbhanda rbhanda added Servicing-approved breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug and removed Servicing-consider labels Oct 7, 2025
@rbhanda rbhanda added this to the 10.0.0 milestone Oct 7, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET SDK Breaking Change Notification email list.

You can refer to the .NET SDK breaking change guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug needs-breaking-change-doc-created Servicing-approved
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dsplaisted @baronfel @lbussell @rbhanda