CA1708: Ignore 'extension' blocks for naming check. #51838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #51716 by preventing the CA1708 analyzer from flagging naming conflicts within C# extension blocks. Extension blocks are a new C# 14 language feature that should be excluded from the identifier case-sensitivity check.
Key Changes:
- Added
IsExtensionproperty accessor forINamedTypeSymbolvia lightup helpers - Modified the analyzer to skip extension blocks when checking for case-only identifier differences
- Added unit test validating that extension blocks with similar names don't trigger warnings
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IdentifiersShouldDifferByMoreThanCaseTests.cs | Added test case with two extension blocks to verify they are excluded from CA1708 checks |
| ISymbolExtensions.cs | Added IsExtension helper method to check if a symbol is an extension block |
| INamedTypeSymbolExtensions.cs | Implemented IsExtension property accessor using lightup helpers for forward compatibility |
| IdentifiersShouldDifferByMoreThanCase.cs | Updated analyzer logic to skip extension blocks during name checking |
Comments suppressed due to low confidence (1)
src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/IdentifiersShouldDifferByMoreThanCaseTests.cs:1
- The test validates that no CA1708 warnings are raised, but doesn't verify that the analyzer still works correctly for non-extension members. Consider adding a case where
ExtensionString,CreateExtension, orIsExtensionStringhave case-only variations (e.g.,extensionString,createExtension) outside of extension blocks to ensure the analyzer still catches those conflicts.
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the MIT license. See License.txt in the project root for license information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51716
IsExtensionforINamedTypeSymbolusingLightupHelpers.IdentifiersShouldDifferByMoreThanCaseAnalyzer