Build Roslyn targeting net5.0

Author: dagood

patches/roslyn/0012-Build-Roslyn-as-net5.0-in-source-build.patch

@@ -0,0 +1,51 @@
+From 44ead158f2e5b0410f600baaa7286ea5bd7545ae Mon Sep 17 00:00:00 2001
+From: Davis Goodin <[email protected]>
+Date: Tue, 29 Dec 2020 00:39:00 -0600
+Subject: [PATCH 3/5] Fix new CS0618 showing up with net5.0
+
+---
+ Directory.Build.props                       |  2 +-
+ src/Compilers/Core/MSBuildTask/Utilities.cs | 14 ++++++++------
+ 2 files changed, 9 insertions(+), 7 deletions(-)
+
+diff --git a/Directory.Build.props b/Directory.Build.props
+index aaa1d5b9fe5..e468e163eb6 100644
+--- a/Directory.Build.props
++++ b/Directory.Build.props
+@@ -4,7 +4,7 @@
+   <Import Project="eng\targets\Settings.props" />
+ 
+   <PropertyGroup>
+-    <WarningsNotAsErrors>$(WarningsNotAsErrors);CS0618;CS8600;CS8602;CS8603;CS8604;CS8777</WarningsNotAsErrors>
++    <WarningsNotAsErrors>$(WarningsNotAsErrors);CS8600;CS8602;CS8603;CS8604;CS8605;CS8777</WarningsNotAsErrors>
+   </PropertyGroup>
+ 
+ </Project>
+diff --git a/src/Compilers/Core/MSBuildTask/Utilities.cs b/src/Compilers/Core/MSBuildTask/Utilities.cs
+index 74da0c2bdd3..b6af0715406 100644
+--- a/src/Compilers/Core/MSBuildTask/Utilities.cs
++++ b/src/Compilers/Core/MSBuildTask/Utilities.cs
+@@ -154,12 +154,14 @@ internal static void DeleteNoThrow(string path)
+ 
+         internal static string? TryGetAssemblyPath(Assembly assembly)
+         {
+-            if (assembly.GlobalAssemblyCache)
+-            {
+-                return null;
+-            }
+-
+-            if (assembly.CodeBase is { } codebase)
++            // Removed: error CS0618: 'Assembly.GlobalAssemblyCache' is obsolete: 'The Global Assembly Cache is not supported.'
++            // if (assembly.GlobalAssemblyCache)
++            // {
++            //     return null;
++            // }
++
++            // error CS0618: 'Assembly.CodeBase' is obsolete: 'Assembly.CodeBase and Assembly.EscapedCodeBase are only included for .NET Framework compatibility. Use Assembly.Location instead.'
++            if (assembly.Location is { } codebase)
+             {
+                 var uri = new Uri(codebase);
+                 return uri.IsFile ? uri.LocalPath : assembly.Location;
+-- 
+2.25.4
+

patches/roslyn/0013-Rename-IReadOnlySet-IRoslynReadOnlySet.patch

@@ -0,0 +1,25 @@
+From a388034e96c856d09209e899bfba66d08c9c6274 Mon Sep 17 00:00:00 2001
+From: Davis Goodin <[email protected]>
+Date: Tue, 29 Dec 2020 00:53:32 -0600
+Subject: [PATCH 5/5] Remove S.Runtime.InteropServices.WindowsRuntime
+
+Doesn't exist and doesn't seem necessary in net5.0.
+---
+ src/Compilers/Server/VBCSCompiler/ClientConnectionHandler.cs | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/src/Compilers/Server/VBCSCompiler/ClientConnectionHandler.cs b/src/Compilers/Server/VBCSCompiler/ClientConnectionHandler.cs
+index 6bda91e310b..ce7b044b208 100644
+--- a/src/Compilers/Server/VBCSCompiler/ClientConnectionHandler.cs
++++ b/src/Compilers/Server/VBCSCompiler/ClientConnectionHandler.cs
+@@ -8,7 +8,6 @@
+ using System.IO;
+ using System.IO.Pipes;
+ using System.Net.Sockets;
+-using System.Runtime.InteropServices.WindowsRuntime;
+ using System.Text;
+ using System.Threading;
+ using System.Threading.Tasks;
+-- 
+2.25.4
+

patches/roslyn/0014-Fix-new-CS0618-showing-up-with-net5.0.patch

@@ -0,0 +1,25 @@
+From dbb2cbb458f0b8d2fcf4af0c3dbb6628e62ea661 Mon Sep 17 00:00:00 2001
+From: Davis Goodin <[email protected]>
+Date: Tue, 29 Dec 2020 01:20:44 -0600
+Subject: [PATCH] Set compilers package targetframework to net5.0
+
+---
+ .../Microsoft.NETCore.Compilers.Package.csproj                  | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/NuGet/Microsoft.NETCore.Compilers/Microsoft.NETCore.Compilers.Package.csproj b/src/NuGet/Microsoft.NETCore.Compilers/Microsoft.NETCore.Compilers.Package.csproj
+index dcb5df09f24..0f3093bdc54 100644
+--- a/src/NuGet/Microsoft.NETCore.Compilers/Microsoft.NETCore.Compilers.Package.csproj
++++ b/src/NuGet/Microsoft.NETCore.Compilers/Microsoft.NETCore.Compilers.Package.csproj
+@@ -1,7 +1,7 @@
+ <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
+ <Project Sdk="Microsoft.NET.Sdk">
+   <PropertyGroup>
+-    <TargetFramework>netcoreapp3.1</TargetFramework>
++    <TargetFramework>$(TargetFrameworkForNETSDK)</TargetFramework>
+ 
+     <IsPackable>true</IsPackable>
+     <ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>
+-- 
+2.25.4
+

patches/roslyn/0015-Add-__Roslyn-to-ReferenceEqualityComparer.patch

@@ -0,0 +1,25 @@
+From 86de24831b17b378c8f7aa5713b93c80300fcd16 Mon Sep 17 00:00:00 2001
+From: Davis Goodin <[email protected]>
+Date: Tue, 29 Dec 2020 01:34:45 -0600
+Subject: [PATCH] Update _RoslynTargetDirectoryName for net5.0
+
+---
+ .../build/Microsoft.Net.Compilers.Toolset.props                 | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/NuGet/Microsoft.Net.Compilers.Toolset/build/Microsoft.Net.Compilers.Toolset.props b/src/NuGet/Microsoft.Net.Compilers.Toolset/build/Microsoft.Net.Compilers.Toolset.props
+index 157388e0be7..aac3dcdee92 100644
+--- a/src/NuGet/Microsoft.Net.Compilers.Toolset/build/Microsoft.Net.Compilers.Toolset.props
++++ b/src/NuGet/Microsoft.Net.Compilers.Toolset/build/Microsoft.Net.Compilers.Toolset.props
+@@ -2,7 +2,7 @@
+ <Project>
+ 
+   <PropertyGroup>
+-    <_RoslynTargetDirectoryName Condition="'$(MSBuildRuntimeType)' == 'Core'">netcoreapp3.1</_RoslynTargetDirectoryName>   
++    <_RoslynTargetDirectoryName Condition="'$(MSBuildRuntimeType)' == 'Core'">net5.0</_RoslynTargetDirectoryName>   
+     <_RoslynTargetDirectoryName Condition="'$(MSBuildRuntimeType)' != 'Core'">net472</_RoslynTargetDirectoryName>   
+     <_RoslynTasksDirectory>$(MSBuildThisFileDirectory)..\tasks\$(_RoslynTargetDirectoryName)\</_RoslynTasksDirectory>
+     <RoslynTasksAssembly>$(_RoslynTasksDirectory)Microsoft.Build.Tasks.CodeAnalysis.dll</RoslynTasksAssembly> 
+-- 
+2.25.4
+

patches/roslyn/0016-Remove-S.Runtime.InteropServices.WindowsRuntime.patch

@@ -0,0 +1,25 @@
+From 96bc47bb4e052a986672efb2108c4f1804b8f1cb Mon Sep 17 00:00:00 2001
+From: Davis Goodin <[email protected]>
+Date: Tue, 29 Dec 2020 02:19:14 -0600
+Subject: [PATCH] Update to use net5.0 Roslyn
+
+---
+ src/Layout/redist/targets/GenerateLayout.targets | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/Layout/redist/targets/GenerateLayout.targets b/src/Layout/redist/targets/GenerateLayout.targets
+index 5b26387c1..48b0303b1 100644
+--- a/src/Layout/redist/targets/GenerateLayout.targets
++++ b/src/Layout/redist/targets/GenerateLayout.targets
+@@ -20,7 +20,7 @@
+       <RoslynDirectory>$(OutputPath)/Roslyn</RoslynDirectory>
+     </PropertyGroup>
+     <ItemGroup>
+-      <RoslynBits Include="$(NuGetPackageRoot)/microsoft.net.compilers.toolset/$(MicrosoftNetCompilersToolsetPackageVersion)/tasks/netcoreapp3.1/**/*" />
++      <RoslynBits Include="$(NuGetPackageRoot)/microsoft.net.compilers.toolset/$(MicrosoftNetCompilersToolsetPackageVersion)/tasks/net5.0/**/*" />
+     </ItemGroup>
+     <Error Condition="'@(RoslynBits)' == ''" Text="Something moved around in Roslyn package, adjust code here accordingly. TFM change?" />
+     <Copy SourceFiles="@(RoslynBits)" DestinationFiles="@(RoslynBits->'$(RoslynDirectory)/%(RecursiveDir)%(Filename)%(Extension)')" />
+-- 
+2.25.4
+