Skip to content

Commit a02c3e1

Browse files
committed
Update TFM patch to match MSBuild TFMs
1 parent d0d4f5f commit a02c3e1

File tree

1 file changed

+49
-12
lines changed

1 file changed

+49
-12
lines changed

patches/fsharp/0006-Use-net5.0-TFM-to-avoid-3.1-apphost-prebuilt.patch

Lines changed: 49 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,25 @@
1-
From 2e75e18f01c08390adb1914c9fe40cce7c3f9ed4 Mon Sep 17 00:00:00 2001
1+
From e71f2b0325d269f63a2373ce63722f4f3046084e Mon Sep 17 00:00:00 2001
22
From: dseefeld <[email protected]>
33
Date: Wed, 24 Mar 2021 15:10:07 +0000
4-
Subject: [PATCH] Use net5.0 TFM to avoid 3.1 apphost prebuilt
4+
Subject: [PATCH 5/5] Use net5.0 TFM to avoid 3.1 apphost prebuilt
55

66
See https://github.com/dotnet/source-build/issues/1905
77
---
88
eng/build.sh | 11 +++---
9-
proto.proj | 4 +--
9+
proto.proj | 6 ++--
1010
.../AssemblyCheck/AssemblyCheck.fsproj | 2 +-
1111
src/buildtools/fslex/fslex.fsproj | 2 +-
1212
src/buildtools/fsyacc/fsyacc.fsproj | 2 +-
13-
.../Microsoft.FSharp.Compiler.csproj | 6 ++--
13+
src/fsharp/FSharp.Build/FSharp.Build.fsproj | 3 +-
14+
.../Microsoft.FSharp.Compiler.csproj | 8 ++---
1415
.../Microsoft.FSharp.Compiler.nuspec | 34 +++++++++----------
1516
src/fsharp/fsc/fsc.fsproj | 1 +
1617
src/fsharp/fsi/fsi.fsproj | 3 +-
17-
9 files changed, 34 insertions(+), 31 deletions(-)
18+
.../VisualFSharpFull/VisualFSharpFull.csproj | 2 +-
19+
11 files changed, 38 insertions(+), 36 deletions(-)
1820

1921
diff --git a/eng/build.sh b/eng/build.sh
20-
index e741ff854..4aa80d6ca 100755
22+
index e741ff854..165ba0b7f 100755
2123
--- a/eng/build.sh
2224
+++ b/eng/build.sh
2325
@@ -244,20 +244,21 @@ function BuildSolution {
@@ -48,11 +50,15 @@ index e741ff854..4aa80d6ca 100755
4850

4951
# do real build
5052
diff --git a/proto.proj b/proto.proj
51-
index bb2f97270..bb0778345 100644
53+
index bb2f97270..6c344c880 100644
5254
--- a/proto.proj
5355
+++ b/proto.proj
54-
@@ -10,10 +10,10 @@
55-
<AdditionalProperties>TargetFramework=netstandard2.0</AdditionalProperties>
56+
@@ -7,13 +7,13 @@
57+
58+
<ItemGroup>
59+
<Projects Include="src\fsharp\FSharp.Build\FSharp.Build.fsproj">
60+
- <AdditionalProperties>TargetFramework=netstandard2.0</AdditionalProperties>
61+
+ <AdditionalProperties>TargetFramework=netcoreapp2.1</AdditionalProperties>
5662
</Projects>
5763
<Projects Include="src\fsharp\fsc\fsc.fsproj">
5864
- <AdditionalProperties Condition="'$(OS)' == 'Unix'">TargetFramework=netcoreapp3.1</AdditionalProperties>
@@ -103,8 +109,22 @@ index a2b8cb384..5d1b7141f 100644
103109
<DefineConstants>INTERNALIZED_FSLEXYACC_RUNTIME;$(DefineConstants)</DefineConstants>
104110
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
105111
</PropertyGroup>
112+
diff --git a/src/fsharp/FSharp.Build/FSharp.Build.fsproj b/src/fsharp/FSharp.Build/FSharp.Build.fsproj
113+
index 3d36804a7..5a9e49bb0 100644
114+
--- a/src/fsharp/FSharp.Build/FSharp.Build.fsproj
115+
+++ b/src/fsharp/FSharp.Build/FSharp.Build.fsproj
116+
@@ -4,8 +4,7 @@
117+
118+
<PropertyGroup>
119+
<OutputType>Library</OutputType>
120+
- <TargetFramework Condition="'$(Configuration)' != 'Proto'">netstandard2.0</TargetFramework>
121+
- <TargetFrameworks Condition="'$(Configuration)' == 'Proto'">netstandard2.0</TargetFrameworks>
122+
+ <TargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
123+
<AssemblyName>FSharp.Build</AssemblyName>
124+
<NoWarn>$(NoWarn);45;55;62;75;1204</NoWarn>
125+
<AllowCrossTargeting>true</AllowCrossTargeting>
106126
diff --git a/src/fsharp/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.csproj b/src/fsharp/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.csproj
107-
index e75296aa7..26620118b 100644
127+
index e75296aa7..d162af011 100644
108128
--- a/src/fsharp/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.csproj
109129
+++ b/src/fsharp/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.csproj
110130
@@ -2,7 +2,7 @@
@@ -116,7 +136,7 @@ index e75296aa7..26620118b 100644
116136
<NuspecFile>Microsoft.FSharp.Compiler.nuspec</NuspecFile>
117137
<IsPackable>true</IsPackable>
118138
<PackageDescription>.NET Core compatible version of the F# compiler fsc.exe.</PackageDescription>
119-
@@ -11,10 +11,10 @@
139+
@@ -11,13 +11,13 @@
120140

121141
<ItemGroup>
122142
<ProjectReference Include="..\fsc\fsc.fsproj">
@@ -128,6 +148,10 @@ index e75296aa7..26620118b 100644
128148
+ <AdditionalProperties>TargetFramework=net5.0</AdditionalProperties>
129149
</ProjectReference>
130150
<ProjectReference Include="..\FSharp.Build\FSharp.Build.fsproj">
151+
- <AdditionalProperties>TargetFramework=netstandard2.0</AdditionalProperties>
152+
+ <AdditionalProperties>TargetFramework=netcoreapp2.1</AdditionalProperties>
153+
</ProjectReference>
154+
<ProjectReference Include="..\FSharp.Compiler.Interactive.Settings\FSharp.Compiler.Interactive.Settings.fsproj">
131155
<AdditionalProperties>TargetFramework=netstandard2.0</AdditionalProperties>
132156
diff --git a/src/fsharp/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.nuspec b/src/fsharp/Microsoft.FSharp.Compiler/Microsoft.FSharp.Compiler.nuspec
133157
index f5cac7b09..933b63b1f 100644
@@ -229,6 +253,19 @@ index 0f1a28f15..5422267a4 100644
229253
<PackageReference Include="System.Diagnostics.Process" Version="$(SystemDiagnosticsProcessVersion)" />
230254
<PackageReference Include="System.Linq.Expressions" Version="$(SystemLinqExpressionsVersion)" />
231255
<PackageReference Include="System.Reflection.Emit" Version="$(SystemReflectionEmitVersion)" />
256+
diff --git a/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj b/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj
257+
index be3261418..7afea0af3 100644
258+
--- a/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj
259+
+++ b/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj
260+
@@ -42,7 +42,7 @@
261+
<NgenArchitecture>All</NgenArchitecture>
262+
<NgenPriority>2</NgenPriority>
263+
<Private>True</Private>
264+
- <AdditionalProperties>TargetFramework=$(DependencyTargetFramework)</AdditionalProperties>
265+
+ <AdditionalProperties>TargetFramework=netcoreapp2.1</AdditionalProperties>
266+
</ProjectReference>
267+
<ProjectReference Include="$(FSharpSourcesRoot)\fsharp\FSharp.Compiler.Interactive.Settings\FSharp.Compiler.Interactive.Settings.fsproj">
268+
<Project>{649FA588-F02E-457C-9FCF-87E46407481E}</Project>
232269
--
233-
2.25.4
270+
2.18.0
234271

0 commit comments

Comments
 (0)