Update implementation plan from last source-build champs meeting (#1714)

* Update implementation plan base on recent source-build champs meeting

* Update implementation plan graph

* Updates based on PR review comments

Author: dseefeld

Documentation/planning/arcade-powered-source-build/img/implementation-plan-graph.dgml

@@ -1,7 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <DirectedGraph Layout="Sugiyama" ZoomLevel="-1" xmlns="http://schemas.microsoft.com/vs/2009/dgml">
   <Nodes>
-    <Node Id="application-insights" Category="Stage2" Label="application-insights" />
+    <Node Id="source-build-reference-packages" Category="Stage5" Label="source-build-reference-packages" />
+    <Node Id="application-insights" Category="Stage1" Label="application-insights" />
     <Node Id="arcade" Category="Stage1" Label="arcade" />
     <Node Id="aspnet-extensions" Category="Stage1" Label="extensions" />
     <Node Id="aspnet-xdt" Category="Stage1" Label="aspnet-xdt" />
@@ -12,9 +13,9 @@
     <Node Id="fsharp" Category="Stage1" Label="fsharp" />
     <Node Id="linker" Category="Stage1" Label="linker" />
     <Node Id="msbuild" Category="Stage1" Label="msbuild" />
-    <Node Id="netcorecli-fsc" Category="Stage2" Label="netcorecli-fsc" />
-    <Node Id="newtonsoft-json" Category="Stage2" Label="newtonsoft-json" />
-    <Node Id="newtonsoft-json901" Category="Stage2" Label="newtonsoft-json901" />
+    <Node Id="netcorecli-fsc" Category="Stage1" Label="netcorecli-fsc" />
+    <Node Id="newtonsoft-json" Category="Stage1" Label="newtonsoft-json" />
+    <Node Id="newtonsoft-json901" Category="Stage1" Label="newtonsoft-json901" />
     <Node Id="nuget-client" Category="Stage1" Label="nuget-client" />
     <Node Id="roslyn" Category="Stage1" Label="roslyn" />
     <Node Id="runtime" Category="Stage1" Label="runtime" />
@@ -24,7 +25,7 @@
     <Node Id="templating" Category="Stage1" Label="templating" />
     <Node Id="vstest" Category="Stage1" Label="vstest" />
     <Node Id="websdk" Category="Stage1" Label="websdk" />
-    <Node Id="xliff-tasks" Category="Stage2" Label="xliff-tasks" />
+    <Node Id="xliff-tasks" Category="Stage1" Label="xliff-tasks" />
   </Nodes>
   <Links>
     <Link Source="application-insights" Target="sdk" />
@@ -117,29 +118,25 @@
       <Condition Expression="HasCategory('Stage1')" />
       <Setter Property="Background" Value="#FFD0CECE" />
     </Style>
-    <Style TargetType="Node" GroupLabel="Stage2 - Patch Removal" ValueLabel="True">
+    <Style TargetType="Node" GroupLabel="Stage2 - Input intermediate pkgs" ValueLabel="True">
       <Condition Expression="HasCategory('Stage2')" />
       <Setter Property="Background" Value="#FFF7CAAC" />
     </Style>
-    <Style TargetType="Node" GroupLabel="Stage3 - Build params to Eng dir" ValueLabel="True">
+    <Style TargetType="Node" GroupLabel="Stage3 - Merge to dev branch" ValueLabel="True">
       <Condition Expression="HasCategory('Stage3')" />
       <Setter Property="Background" Value="#FFFFE599" />
     </Style>
-    <Style TargetType="Node" GroupLabel="Stage4 - Input intermediate pkgs" ValueLabel="True">
+    <Style TargetType="Node" GroupLabel="Stage4 - Setup CI / Mock official build" ValueLabel="True">
       <Condition Expression="HasCategory('Stage4')" />
       <Setter Property="Background" Value="#FFF0FE86" />
     </Style>
-    <Style TargetType="Node" GroupLabel="Stage5 - Official build" ValueLabel="True">
+    <Style TargetType="Node" GroupLabel="Stage5 - Validate / Merge to 5.0" ValueLabel="True">
       <Condition Expression="HasCategory('Stage5')" />
       <Setter Property="Background" Value="#FFB4C6E7" />
     </Style>
-    <Style TargetType="Node" GroupLabel="Stage6 - Source-build PR validation" ValueLabel="True">
+    <Style TargetType="Node" GroupLabel="Stage6 - Prebuilt baseline enforcment" ValueLabel="True">
       <Condition Expression="HasCategory('Stage6')" />
       <Setter Property="Background" Value="#FFCFAFE7" />
     </Style>
-    <Style TargetType="Node" GroupLabel="Stage7 - Prebuilt check / enforcement" ValueLabel="True">
-      <Condition Expression="HasCategory('Stage7')" />
-      <Setter Property="Background" Value="#FFA8D08D" />
-    </Style>
   </Styles>
 </DirectedGraph>

Documentation/planning/arcade-powered-source-build/img/implementation-plan-graph.png

@@ -5,30 +5,30 @@ To get each repo building with the new source-build 5.0 plan, [Arcade-Powered So
 > ![](img/implementation-plan-graph.png)
 > [source (img/implementation-plan-graph.dgml)](img/implementation-plan-graph.dgml)
 
-| Tier | Repo | Owner | (Stage 1)<br>Build from source - 5.0 | (Stage 2)<br>Patch Removal | (Stage 3)<br>Move build params to eng dir | (Stage 4)<br>Input Intermediate Packages Available | (Stage 5)<br>Official build | (Stage 6)<br>Source-build PR validation | (Stage 7)<br>Prebuilt check / enforcement |
-| --- | --- | --- | :---: | :---: | :---: | :---: | :---: | :---: | :---: |
-| sbrp | Source-build-reference-packages | [Dan Seefeldt](https://github.com/dseefeld) | ✔️ | ✔️ | | | | | |
-| Tools | sourcelink | [Tomas Matousek](https://github.com/tmat) | ✔️ | 4 | | | | | |
-| Tools | arcade | [Mark Wilkie](https://github.com/markwilkie) | ✔️ | ⏱ 11 | | | | | |
-| 1 | application-insights | [Reiley Yang](https://github.com/reyang) | ✔️ | ✔️ | | | | | |
-| 1 | aspnet-xdt | [Vijay Ramakrishnan](https://github.com/vijayrkn) | ✔️ | 2 | | | | | |
-| 1 | newtonsoft-json | [Chris Rummel](https://github.com/crummel) | ✔️ | ✔️ | | | | | |
-| 1 | netcorecli-fsc | [Chris Rummel](https://github.com/crummel) | ✔️ | ✔️ | | | | | |
-| 1 | newtonsoft-json901 | [Chris Rummel](https://github.com/crummel) | ✔️ | ✔️ | | | | | |
-| 1 | xliff-tasks | [William Li](https://github.com/wli3) | ✔️ | 1 | | | | | |
-| 1 | clicommandlineparser | [Sarah Oslund](https://github.com/sfoslund) | ✔️ | 1 | | | | | |
-| 1 | roslyn | [Fred Silberberg](https://github.com/333fred) | ✔️ | 5 | | | | | |
-| 2 | linker | [Dan Seefeldt](https://github.com/dseefeld) | ✔️ | 3 | | | | | |
-| 2 | runtime | [Jared Parsons](https://github.com/jaredpar) | ✔️ | 15 | | | | | |
-| 2 | msbuild | [Ben Villalobos](https://github.com/BenVillalobos) | ✔️ | 4 | | | | | |
-| 2 | NuGet.Client | [Fernando Aguilar Reyes](https://github.com/dominoFire) | ✔️ | ⏱ 10 | | | | | |
-| 2 | templating | [Jose Aguilar](https://github.com/donJoseLuis) | ✔️ | ✔️ | | | | | |
-| 3 | aspnetcore | [John Luo](https://github.com/JunTaoLuo) | ✔️ | 13 | | | | | |
-| 3 | websdk | [Vijay Ramakrishnan](https://github.com/vijayrkn) | ✔️ | 1 | | | | | |
-| 4 | sdk | [Sarah Oslund](https://github.com/sfoslund) | ✔️ | 9 | | | | | |
-| 4 | vstest | [Jakub Jares](https://github.com/nohwnd) | ✔️ | 7 | | | | | |
-| 4 | fsharp | [Brett Forsgren](https://github.com/brettfo) | ✔️ | 4 | | | | | |
-| 5 | installer | [Sarah Oslund](https://github.com/sfoslund) | ✔️ | 3 | | | | | |
+| Tier | Repo | Owner | (Stage 1)<br>Build from source - 5.0 | (Stage 2)<br>Input intermediate packages available | (Stage 3)<br>Merge patches & local build infra into dev branch | (Stage 4)<br>Merge CI, generate mock official build | (Stage 5)<br>Validate & merge dev branch into 5.0 | (Stage 6)<br>Prebuilt baseline enforcement |
+| --- | --- | --- | :---: | :---: | :---: | :---: | :---: | :---: |
+| sbrp | Source-build-reference-packages | [Dan Seefeldt](https://github.com/dseefeld) | ✔️ | ✔️ | ⏱ [#1715](https://github.com/dotnet/source-build/issues/1715) | ✔️ | ✔️ | |
+| Tools | sourcelink | [Tomas Matousek](https://github.com/tmat) | ✔️ | | | | | |
+| Tools | arcade | [Mark Wilkie](https://github.com/markwilkie) | ✔️ | | | | | |
+| 1 | application-insights | [Reiley Yang](https://github.com/reyang) | ✔️ | | | | | |
+| 1 | aspnet-xdt | [Vijay Ramakrishnan](https://github.com/vijayrkn) | ✔️ | | | | | |
+| 1 | newtonsoft-json | [Chris Rummel](https://github.com/crummel) | ✔️ | | | | | |
+| 1 | netcorecli-fsc | [Chris Rummel](https://github.com/crummel) | ✔️ | | | | | |
+| 1 | newtonsoft-json901 | [Chris Rummel](https://github.com/crummel) | ✔️ | | | | | |
+| 1 | xliff-tasks | [William Li](https://github.com/wli3) | ✔️ | | | | | |
+| 1 | clicommandlineparser | [Sarah Oslund](https://github.com/sfoslund) | ✔️ | | | | | |
+| 1 | roslyn | [Fred Silberberg](https://github.com/333fred) | ✔️ | | | | | |
+| 2 | linker | [Dan Seefeldt](https://github.com/dseefeld) | ✔️ | | | | | |
+| 2 | runtime | [Jared Parsons](https://github.com/jaredpar) | ✔️ | | | | | |
+| 2 | msbuild | [Ben Villalobos](https://github.com/BenVillalobos) | ✔️ | | | | | |
+| 2 | NuGet.Client | [Fernando Aguilar Reyes](https://github.com/dominoFire) | ✔️ | | | | | |
+| 2 | templating | [Jose Aguilar](https://github.com/donJoseLuis) | ✔️ | | | | | |
+| 3 | aspnetcore | [John Luo](https://github.com/JunTaoLuo) | ✔️ | | | | | |
+| 3 | websdk | [Vijay Ramakrishnan](https://github.com/vijayrkn) | ✔️ | | | | | |
+| 4 | sdk | [Sarah Oslund](https://github.com/sfoslund) | ✔️ | | | | | |
+| 4 | vstest | [Jakub Jares](https://github.com/nohwnd) | ✔️ | | | | | |
+| 4 | fsharp | [Brett Forsgren](https://github.com/brettfo) | ✔️ | | | | | |
+| 5 | installer | [Sarah Oslund](https://github.com/sfoslund) | ✔️ | | | | | |
 
 | Status | Description |
 | --- | --- |
@@ -37,21 +37,9 @@ To get each repo building with the new source-build 5.0 plan, [Arcade-Powered So
 | ❗ | At Risk |
 
 ## Stage descriptions:
-  - **(1) Build from Source 5.0** – Get repo building from source with 5.0 source in dotnet/source-build.
-  - **(2) Patch Removal** – Incorporate patches required to build from source into the repo code base.
-  - **(3) Move Build Params to Eng Dir** – Move all source-build specific build parameter from `/repos/<reponame>.proj` in source-build repo to repo `/eng` directory.
-  - **(4) Input Intermediate Packages Available** – Indicates upstream intermediate packages are available, and work on this repo can begin.
-  - **(5) Official build** – Build source-built intermediate packages in official build.
-  - **(6) Source-build PR validation** – Add AzDO build jobs to PR validation to ensure build-from-source continues running without avoidable regressions.
-  - **(7) Prebuilt check / enforcement** – Add a check to PR validation to ensure that no prebuilts are included when building repo.
-
-## Key Milestone Dates:
-
-| Stage(s) | Start | End |
-| --- | :---: | :---: |
-| Stage 1 - Build from Source 5.0 | 2020-05-28 | 2020-06-29 |
-| Stage 2 - Patch Removal | 2020-06-16 | 2020-07-23 |
-| Stages 3-5 - Get into Official Build | 2020-06-25 | 2020-09-16 |
-| Stages 6-7 - PR Validation / Prebuilt check | 2020-07-28 | 2020-10-05 |
-
-
+  - **(1) Build from source 5.0** – Get repo building from source with 5.0 source in dotnet/source-build.
+  - **(2) Input intermediate packages available** – Indicates upstream intermediate packages are available, and work on this repo can begin.
+  - **(3) Merge patches & local build infra into dev branch** – Repo owner has created source-build dev branch.  Move all source-build specific build parameters from `/repos/<reponame>.proj` in source-build repo to repo `/eng` directory and add repo-specific patches into source-build dev branch.
+  - **(4) Merge CI, generate mock official build** – PR validation and Official Build CI jobs added to source-build dev branch and run to generate intermediate package for repo. 
+  - **(5) Validate & merge dev branch into 5.0** – Build logs and intermediate package reviewed and validated by source-build team.  Source-build changes are live for repo in 5.0 branch.  Build source-built intermediate packages in official build.
+  - **(6) Prebuilt baseline enforcement** – Prebuilt checks enforcment enabled in PR validation builds.  Builds fail if new prebuilts are introduced.