Skip to content

Commit ddd53c2

Browse files
committed
Another couple fixes for roslyn-analyzer
1 parent 235b7e6 commit ddd53c2

File tree

1 file changed

+56
-11
lines changed

1 file changed

+56
-11
lines changed
Lines changed: 56 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,69 @@
1-
From 1d441b6136ba0325b740665807f7783f90713b92 Mon Sep 17 00:00:00 2001
1+
From adabb4c0fc30a367055e13a3fbff00784310e496 Mon Sep 17 00:00:00 2001
22
From: Chris Rummel <[email protected]>
33
Date: Thu, 1 Apr 2021 17:46:44 -0500
44
Subject: [PATCH 12/12] Fix ambiguous reference.
55

66
---
7-
.../CSharp/WrapStatements/CSharpWrapStatementsFixAllProvider.cs | 1 -
8-
1 file changed, 1 deletion(-)
7+
.../Maintainability/CodeMetricsAnalyzer.cs | 10 +++++-----
8+
.../CSharpBracePlacementFixAllProvider.cs | 2 +-
9+
.../CSharpWrapStatementsFixAllProvider.cs | 2 +-
10+
3 files changed, 7 insertions(+), 7 deletions(-)
911

12+
diff --git a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/CodeMetricsAnalyzer.cs b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/CodeMetricsAnalyzer.cs
13+
index a15e8a073..351d459e1 100644
14+
--- a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/CodeMetricsAnalyzer.cs
15+
+++ b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/CodeMetricsAnalyzer.cs
16+
@@ -316,13 +316,13 @@ static bool isApplicableByDefault(string ruleId, SymbolKind symbolKind)
17+
// Compat: we match the default threshold values for old FxCop implementation.
18+
return ruleId switch
19+
{
20+
- CA1501RuleId => 5,
21+
+ CA1501RuleId => (uint)5,
22+
23+
- CA1502RuleId => 25,
24+
+ CA1502RuleId => (uint)25,
25+
26+
- CA1505RuleId => 10,
27+
+ CA1505RuleId => (uint)10,
28+
29+
- CA1506RuleId => symbolKind == SymbolKind.NamedType ? 95 : 40,
30+
+ CA1506RuleId => symbolKind == SymbolKind.NamedType ? (uint)95 : (uint)40,
31+
32+
_ => throw new NotImplementedException(),
33+
};
34+
@@ -505,4 +505,4 @@ private static int GetDistinctContainingNamespacesCount(IEnumerable<INamedTypeSy
35+
return distinctNamespaces.Count;
36+
}
37+
}
38+
-}
39+
\ No newline at end of file
40+
+}
41+
diff --git a/src/Roslyn.Diagnostics.Analyzers/CSharp/BracePlacement/CSharpBracePlacementFixAllProvider.cs b/src/Roslyn.Diagnostics.Analyzers/CSharp/BracePlacement/CSharpBracePlacementFixAllProvider.cs
42+
index f27881062..ecbbb77fb 100644
43+
--- a/src/Roslyn.Diagnostics.Analyzers/CSharp/BracePlacement/CSharpBracePlacementFixAllProvider.cs
44+
+++ b/src/Roslyn.Diagnostics.Analyzers/CSharp/BracePlacement/CSharpBracePlacementFixAllProvider.cs
45+
@@ -9,7 +9,7 @@
46+
47+
namespace Roslyn.Diagnostics.CSharp.Analyzers.BracePlacement
48+
{
49+
- internal class CSharpBracePlacementFixAllProvider : DocumentBasedFixAllProvider
50+
+ internal class CSharpBracePlacementFixAllProvider : StyleCop.Analyzers.Helpers.DocumentBasedFixAllProvider
51+
{
52+
protected override string CodeActionTitle
53+
=> RoslynDiagnosticsAnalyzersResources.Remove_blank_lines_between_braces;
1054
diff --git a/src/Roslyn.Diagnostics.Analyzers/CSharp/WrapStatements/CSharpWrapStatementsFixAllProvider.cs b/src/Roslyn.Diagnostics.Analyzers/CSharp/WrapStatements/CSharpWrapStatementsFixAllProvider.cs
11-
index cc0e65411..302051f4d 100644
55+
index cc0e65411..8bdd97369 100644
1256
--- a/src/Roslyn.Diagnostics.Analyzers/CSharp/WrapStatements/CSharpWrapStatementsFixAllProvider.cs
1357
+++ b/src/Roslyn.Diagnostics.Analyzers/CSharp/WrapStatements/CSharpWrapStatementsFixAllProvider.cs
14-
@@ -3,7 +3,6 @@
15-
using System.Collections.Immutable;
16-
using System.Threading.Tasks;
17-
using Microsoft.CodeAnalysis;
18-
-using Microsoft.CodeAnalysis.CodeFixes;
19-
using Roslyn.Diagnostics.Analyzers;
20-
using StyleCop.Analyzers.Helpers;
58+
@@ -9,7 +9,7 @@
2159

60+
namespace Roslyn.Diagnostics.CSharp.Analyzers.WrapStatements
61+
{
62+
- internal class CSharpWrapStatementsFixAllProvider : DocumentBasedFixAllProvider
63+
+ internal class CSharpWrapStatementsFixAllProvider : StyleCop.Analyzers.Helpers.DocumentBasedFixAllProvider
64+
{
65+
protected override string CodeActionTitle
66+
=> RoslynDiagnosticsAnalyzersResources.Place_statement_on_following_line;
2267
--
2368
2.18.0
2469

0 commit comments

Comments
 (0)