Skip to content

Fix job dependencies for the source-build validation jobs #5100

@akoeplinger

Description

@akoeplinger

Noticed this in https://dev.azure.com/dnceng/internal/_build/results?buildId=2694588&view=logs&j=4534539b-f36a-5744-4ac5-78964eb6810b&s=0a81c10d-160f-5165-c351-fe6e2182207d (Attempt 2)

The CentOSStream9_SourceBuild_Online_MsftSdk_Validation_x64 job ran and tried to download an artifact from the Windows_x64 job, but that one failed so it couldn't download.

That job shouldn't have even run in that case.

I think it's because of this logic:

https://github.com/dotnet/sdk/blob/98eef9763e295085d4d6d184398630ee67fd5c6c/eng/pipelines/templates/jobs/vmr-build.yml#L157-L172

It sets condition: succeededOrFailed(), this likely needs to be revisited now that we have more build passes/stages

/cc @mthalman

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions