Intermittent poison test failure: Value is not null

[mthalman]

This failure is still appearing intermittently for the Microsoft.DotNet.SourceBuild.Tests.PoisonTests.VerifyUsage test:

Assert.Null() Failure: Value is not null
Expected: null
Actual:   "\nExpected file '/__w/1/s/artifacts/bin/Microsoft."···

Example build (internal link)

[MichaelSimons]

While the poison leaks were baselined as acceptable, the baseline entries are different based on where the packages are read from - reference packages versus PSB/reference packages. In the former the Type is SourceBuildReferenceAssembly while the later is AssemblyAttribute.

[ViktorHofer]

This (the poison file not being found) regressed with dotnet/dotnet@83f0c72 and will be fixed by dotnet/dotnet#176

[MichaelSimons]

This (the poison file not being found) regressed with dotnet/dotnet@83f0c72 and will be fixed by dotnet/dotnet#176

@ViktorHofer - I think you are referring to the following failure as seen in this build:

System.InvalidOperationException : Poison report '/__w/1/s/artifacts/log/Release/poison-usage.xml' does not exist.

The original issue is about a known poison leak that get's reported differently based on where nuget resolves the package from.

[MichaelSimons]

[Triage] We are looking for a low cost solution to address this allowed poison usage to get green builds. The long term direction is to remove the reference packages from previous source build artifacts.

[NikolaMilosavljevic]

Fixed with dotnet/dotnet#502