Skip to content

License scan test generates PR that incorrectly deletes baseline file #5123

@mthalman

Description

@mthalman

Example PR: dotnet/dotnet#375, specifically commit dotnet/dotnet@112cec1.

This happens when a repo in the VMR has a license baseline file associated with it and the license scan job for that repo has some kind of failure which causes it to not produce an updated baseline file.

For example, in this pipeline run (internal link), there were timeout errors for a few .il files. This caused the exit code of scancode to be non-zero which prevented the test from continuing to produce an updated baseline file. Since no updated baseline file exists for that job, the PR publishing logic assumes that the baseline file is no longer needed and deletes it from the repo. There needs to be recognition that scancode failed and no changes should be made for that repo's baseline.

Metadata

Metadata

Assignees

Labels

area-testingImprovements in CI and testingops-monitorIssues created/handled by the source build monitor role

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions