LicenseScan test failing due to AttributeError: 'EnhancedProgressBar' object has no attribute 'is_hidden'.

[Winniexu01]

https://dev.azure.com/dnceng/internal/_build/results?buildId=2707216&view=logs&j=7bc8c5b1-8817-5c6c-75ee-0408e3062ddf&t=f53f22f0-3110-5d6d-535a-5589180bb065 (internal Microsoft link)

[xUnit.net 00:00:58.37]       System.InvalidOperationException : Failed to execute scancode --license --processes 4 --timeout 240 --strip-root --only-findings --ignore *.bin --ignore *.bmp --ignore *.bson --ignore *.db --ignore *.dic --ignore *.eot --ignore *.gif --ignore *.ico --ignore *.jpg --ignore *.il --ignore *.ildump --ignore *.lss --ignore *.nlp --ignore *.otf --ignore *.pdf --ignore *.pfx --ignore *.png --ignore *.snk --ignore *.ttf --ignore *.vsd --ignore *.vsdx --ignore *.winmd --ignore *.woff --ignore *.woff2 --ignore *.xlsx --json-pp /mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net8.0/logs/scancode-results.json /mnt/vss/_work/1/s/src/roslyn/
[xUnit.net 00:00:58.37]       Exit code: 1
[xUnit.net 00:00:58.37]       
[xUnit.net 00:00:58.37]       Setup plugins...
[xUnit.net 00:00:58.37]       Collect file inventory...
[xUnit.net 00:00:58.37]       Scan files for: licenses with 4 process(es)...
[xUnit.net 00:00:58.37]       Removing temporary files...done.
[xUnit.net 00:00:58.37]       Traceback (most recent call last):
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/bin/scancode", line 8, in <module>
[xUnit.net 00:00:58.37]           sys.exit(scancode())
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/click/core.py", line 1442, in __call__
[xUnit.net 00:00:58.37]           return self.main(*args, **kwargs)
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/commoncode/cliutils.py", line 73, in main
[xUnit.net 00:00:58.37]           return click.Command.main(
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/click/core.py", line 1363, in main
[xUnit.net 00:00:58.37]           rv = self.invoke(ctx)
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/click/core.py", line 1226, in invoke
[xUnit.net 00:00:58.37]           return ctx.invoke(self.callback, **ctx.params)
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/click/core.py", line 794, in invoke
[xUnit.net 00:00:58.37]           return callback(*args, **kwargs)
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/click/decorators.py", line 34, in new_func
[xUnit.net 00:00:58.37]           return f(get_current_context(), *args, **kwargs)
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/scancode/cli.py", line 487, in scancode
[xUnit.net 00:00:58.37]           success, _results = run_scan(
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/scancode/cli.py", line 944, in run_scan
[xUnit.net 00:00:58.37]           scan_success = run_scanners(
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/scancode/cli.py", line 1186, in run_scanners
[xUnit.net 00:00:58.37]           scan_success = scan_codebase(
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/scancode/cli.py", line 1285, in scan_codebase
[xUnit.net 00:00:58.37]           scans.__enter__()
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/click/_termui_impl.py", line 118, in __enter__
[xUnit.net 00:00:58.37]           self.render_progress()
[xUnit.net 00:00:58.37]         File "/tmp/scancode-env/lib/python3.10/site-packages/commoncode/cliutils.py", line 199, in render_progress
[xUnit.net 00:00:58.38]           if not self.is_hidden:
[xUnit.net 00:00:58.38]       AttributeError: 'EnhancedProgressBar' object has no attribute 'is_hidden'. Did you mean: 'hidden'?
[xUnit.net 00:00:58.38]       Stack Trace:
[xUnit.net 00:00:58.38]         /mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/ExecuteHelper.cs(129,0): at Microsoft.DotNet.SourceBuild.SmokeTests.ExecuteHelper.ValidateExitCode(ValueTuple`3 result, Int32 expectedExitCode)
[xUnit.net 00:00:58.38]         /mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/ExecuteHelper.cs(115,0): at Microsoft.DotNet.SourceBuild.SmokeTests.ExecuteHelper.ExecuteProcessValidateExitCode(String fileName, String args, ITestOutputHelper outputHelper)
[xUnit.net 00:00:58.38]         /mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/LicenseScanTests.cs(155,0): at Microsoft.DotNet.SourceBuild.SmokeTests.LicenseScanTests.ScanForLicenses()
[xUnit.net 00:00:58.38]            at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
[xUnit.net 00:00:58.38]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
[xUnit.net 00:00:58.38]       Output:
[xUnit.net 00:00:58.38]         Executing: scancode --license --processes 4 --timeout 240 --strip-root --only-findings --ignore *.bin --ignore *.bmp --ignore *.bson --ignore *.db --ignore *.dic --ignore *.eot --ignore *.gif --ignore *.ico --ignore *.jpg --ignore *.il --ignore *.ildump --ignore *.lss --ignore *.nlp --ignore *.otf --ignore *.pdf --ignore *.pfx --ignore *.png --ignore *.snk --ignore *.ttf --ignore *.vsd --ignore *.vsdx --ignore *.winmd --ignore *.woff --ignore *.woff2 --ignore *.xlsx --json-pp /mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net8.0/logs/scancode-results.json /mnt/vss/_work/1/s/src/roslyn/
[xUnit.net 00:00:58.38]   Finished:    Microsoft.DotNet.SourceBuild.SmokeTests

[mthalman]

I suspect this is caused by an updated dependency being brought in when scancode is installed since we're installing the same version of scancode as previously working runs. I did notice that a newer version of scancode is available, 32.3.3, while we were only using 32.3.2. But testing with the newer version yielded the same error.

Note that this is working in the main branch because it is using a container job which is using an image which, it would seem, hasn't been rebuilt recently enough to bring in whatever new update caused this regression.

[Winniexu01]

self.is_hidden has been updated to self.hidden in Click-8.2.0: https://github.com/pallets/click/blob/main/src/click/_termui_impl.py#L68

Downgrading click to 8.1.8 can make the test pass.

[Winniexu01]

The builds with scancode==32.3.3 and click==8.1.8:
8.0 build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2710351 (internal Microsoft link) (green)
9.0 build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2710346 (internal Microsoft link) (green)
10.0 build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2710581 (internal Microsoft link) (in progress)