[internal/release/9.0.1xx] Scenario tests failing due to invalid XML comment in generated NuGet.Config

[ellahathaway]

Several of the scenario tests are failing with the following error:

/vmr/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/extracted-sdk/sdk/9.0.111/NuGet.targets(741,5): NuGet.Config is not valid XML. Path: '/vmr/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/projects-<projectid>/NuGet.Config'.
  An XML comment cannot contain '--', and '-' cannot be the last character. Line 65, position 12.

Link to build

[ellahathaway]

I don't see anything obvious in the test binlog or source code. I'm now running a diagnostic run the produce the scenario test nuget.config files as artifacts: https://dev.azure.com/dnceng/internal/_build/results?buildId=2802720&view=results

[MichaelSimons]

It would sure be nice if we captured the test nuget.configs in the test project binlogs...

[ellahathaway]

This line in the NuGet.Config is causing the error:

<!-- <!-- Reenabled for build : <source> --> -->

The feed was disabled in this PR, and then this section of SetupNugetSources.sh is generating the faulty comment.

[ellahathaway]

PR: https://dev.azure.com/dnceng/internal/_git/dotnet-sdk/pullrequest/53831

[ellahathaway]

It would sure be nice if we captured the test nuget.configs in the test project binlogs...

Agreed. Maybe we can capture them as diagnostic log messages? Otherwise, I'm not sure how they would get included.

[mthalman]

You can embed arbitrary files into the binlog. Here's an example:

https://github.com/dotnet/dotnet/blob/f4b7bd12733f53a99cb8dd2564c77e2e6f10a05d/repo-projects/Directory.Build.targets#L281

[ellahathaway]

PR merged, closing