Feature bands: Stage 2 builds should not consume 1xx shared components

[mthalman]

Currently the VMR pipeline is configured so that SB stage 2 legs will consume the 1xx shared components for the build of the 2xx branch. This should not be necessary since the stage 1 artifacts should already contain all the runtime-related packages. In other words, the stage 1 artifacts that are already provided as input to stage 2 should have all the packages that are needed.

[MichaelSimons]

[Triage] It feels like this may be incorrect. 1xx PSB should be used just like a non-bootstrap build would.

[mthalman]

[Triage] It feels like this may be incorrect. 1xx PSB should be used just like a non-bootstrap build would.

Perhaps there's some misunderstanding here. The packages that exist in the 2xx stage 1 output are a superset of the packages that exist in the 1xx shared components. They are literally just copied from shared components to be included in the 2xx output. So I'm not understanding what is incorrect here with not including shared component artifacts as a separate input to the stage 2 build. It's essentially redundant.

[MichaelSimons]

I think I see what you are proposing now. Illustrating with the build cmd line would help clarify. Is this correct?

# Build the 2xx SDK - stage 1
./build.sh --source-only \
  --with-sdk /path/to/previous-source-built-2xx/sdk \
  --with-packages /path/to/previous-source-built-2xx/artifacts \
  --with-shared-components /path/to/current-source-built-1xx/artifacts

# Build the 2xx SDK - stage 2
./build.sh --source-only \
  --with-sdk /path/to/what-was-just-source-built-2xx/sdk \
  --with-packages /path/to/what-was-just-source-built-2xx/artifacts \

If this is the case, should we set 'HasSharedComponents'? Would we be better off testing exactly how we prescribe distro maintainers should supply the arguments?

[mthalman]

Yes, those commands are correct.

If this is the case, should we set 'HasSharedComponents'?

Not sure what you mean by this.

Would we be better off testing exactly how we prescribe distro maintainers should supply the arguments?

That's a broader question. We don't even do this today for 1xx. For example, we don't use --with-packages in the pipeline.

[MichaelSimons]

Yes, those commands are correct.

If this is the case, should we set 'HasSharedComponents'?

Not sure what you mean by this.

I recall there is a HasSharedComponents msbuild property. Any non-1xx build logically "has shared components". Maybe that property really only means we have a shared components tarball.

Would we be better off testing exactly how we prescribe distro maintainers should supply the arguments?

That's a broader question. We don't even do this today for 1xx. For example, we don't use --with-packages in the pipeline.

There is an issue for that. I would prefer we avoid adding to the problem given this is new.