10.0 fails to build with NU5104 error while building msbuild

[tmds]

Our CI builds started failing due to a recent change.

dotnet/dotnet@43556b3 is good. dotnet/dotnet@c9bbb73 is bad.

/home/tester/workdir/dotnet/repo-projects/Directory.Build.targets(599,5): error MSB3073: The command "/home/tester/workdir/dotnet/src/msbuild/eng/common/build.sh --restore --build --pack --publish  --sourceBuild --fromVMR --configuration Release --verbosity minimal /p:TargetRid=fedora.41-x64 /p:OfficialBuildId=20251014.101 /p:DotNetPackageVersionPropsPath=/home/tester/workdir/dotnet/artifacts/obj/PackageVersions/PackageVersions.msbuild.props /p:SourceBuiltAssetsDir=/home/tester/workdir/dotnet/artifacts/assets/Release/ /p:SourceBuiltAssetManifestsDir=/home/tester/workdir/dotnet/artifacts/obj/manifests/Release/msbuild/ /p:RepositoryName=msbuild /p:RepositoryUrl=https://github.com/dotnet/dotnet /p:PreviouslySourceBuiltNupkgCacheDir="/home/tester/workdir/dotnet/prereqs/packages/previously-source-built/" /p:ReferencePackageNupkgCacheDir="/home/tester/workdir/dotnet/prereqs/packages/reference/" /p:TrackPrebuiltUsageReportDir="/home/tester/workdir/dotnet/artifacts/log/Release/msbuild/" /p:TargetArchitecture=x64 /p:TargetOS=linux /p:SourceBuiltShippingPackagesDir=/home/tester/workdir/dotnet/artifacts/packages/Release/Shipping/msbuild/ /p:SourceBuiltNonShippingPackagesDir=/home/tester/workdir/dotnet/artifacts/packages/Release/NonShipping/msbuild/ /p:SourceBuiltPdbArtifactsDir=/home/tester/workdir/dotnet/artifacts/SymStore/Release/msbuild/ /p:SourceBuiltArtifactsBasePath=/home/tester/workdir/dotnet/ /p:UsingToolMicrosoftNetCompilers=false /p:PortableBuild=false /p:PortableTargetRid=linux-x64 /p:RepoOriginalSourceRevisionId=ef8ee47aa94a43657e516677db73ed77bdbe92bf  -bl /p:EnableNgenOptimization=false > /home/tester/workdir/dotnet/artifacts/log/Release/msbuild/msbuild.log 2>&1" exited with code 1. [/home/tester/workdir/dotnet/repo-projects/msbuild.proj]
  
    Determining projects to restore...
    Restored /home/tester/workdir/dotnet/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj (in 183 ms).
    Determining projects to restore...
    Restored /home/tester/workdir/dotnet/src/msbuild/src/StringTools/StringTools.csproj (in 135 ms).
    Restored /home/tester/workdir/dotnet/src/msbuild/src/Utilities/Microsoft.Build.Utilities.csproj (in 158 ms).
    Restored /home/tester/workdir/dotnet/src/msbuild/src/MSBuild/MSBuild.csproj (in 158 ms).
    Restored /home/tester/workdir/dotnet/src/msbuild/src/Package/Localization/Localization.csproj (in 158 ms).
    Restored /home/tester/workdir/dotnet/src/msbuild/src/Framework/Microsoft.Build.Framework.csproj (in 180 ms).
    Restored /home/tester/workdir/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj (in 206 ms).
    Restored /home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj (in 269 ms).
    StringTools -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/StringTools/Release/net10.0/Microsoft.NET.StringTools.dll
    Microsoft.Build.Framework -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/Microsoft.Build.Framework/Release/netstandard2.0/Microsoft.Build.Framework.dll
    Microsoft.Build.Framework -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/Microsoft.Build.Framework/Release/net10.0/Microsoft.Build.Framework.dll
    StringTools -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/StringTools/Release/netstandard2.0/Microsoft.NET.StringTools.dll
    Successfully created package '/home/tester/workdir/dotnet/src/msbuild/artifacts/packages/Release/Shipping/Microsoft.NET.StringTools.18.0.0.nupkg'.
    Microsoft.Build.Utilities -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/Microsoft.Build.Utilities/Release/net10.0/Microsoft.Build.Utilities.Core.dll
    Microsoft.Build.Utilities -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/Microsoft.Build.Utilities/Release/netstandard2.0/Microsoft.Build.Utilities.Core.dll
    Microsoft.Build.Tasks -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/Microsoft.Build.Tasks/Release/netstandard2.0/Microsoft.Build.Tasks.Core.dll
    Microsoft.Build.Tasks -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/Microsoft.Build.Tasks/Release/net10.0/Microsoft.Build.Tasks.Core.dll
    Microsoft.Build -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/Microsoft.Build/Release/net10.0/Microsoft.Build.dll
    Successfully created package '/home/tester/workdir/dotnet/src/msbuild/artifacts/packages/Release/Shipping/Microsoft.Build.Framework.18.0.0.nupkg'.
    MSBuild -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/MSBuild/Release/net10.0/MSBuild.dll
    Successfully created package '/home/tester/workdir/dotnet/src/msbuild/artifacts/packages/Release/Shipping/Microsoft.Build.18.0.0.nupkg'.
    Localization -> /home/tester/workdir/dotnet/src/msbuild/artifacts/bin/Localization/Release/net10.0/Localization.dll
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Configuration.ConfigurationManager [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Utilities/Microsoft.Build.Utilities.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Diagnostics.EventLog [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Utilities/Microsoft.Build.Utilities.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Security.Cryptography.ProtectedData [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Utilities/Microsoft.Build.Utilities.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.CodeDom [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Resources.Extensions [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Security.Cryptography.Pkcs [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Security.Cryptography.Xml [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Configuration.ConfigurationManager [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Diagnostics.EventLog [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Formats.Nrbf [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj]
  /home/tester/workdir/dotnet/.dotnet/sdk/10.0.100-rc.1.25451.107/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: Warning As Error: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Security.Cryptography.ProtectedData [10.0.0-rtm.25514.101, )" or update the version field in the nuspec. [/home/tester/workdir/dotnet/src/msbuild/src/Tasks/Microsoft.Build.Tasks.csproj]
    Successfully created package '/home/tester/workdir/dotnet/src/msbuild/artifacts/packages/Release/NonShipping/Microsoft.Build.Localization.18.0.0-servicing-25514-101.nupkg'.
    Successfully created package '/home/tester/workdir/dotnet/src/msbuild/artifacts/packages/Release/Shipping/Microsoft.Build.Runtime.18.0.0.nupkg'.
  
  Build FAILED.

cc @ViktorHofer @omajid

[ViktorHofer]

@mmitche @rainersigwald

[rainersigwald]

Ah fascinating--should VMR be overwriting our repo's opinion about whether we're stable or not? Going forward we'll have frequent-ish stable releases that may not align with the .NET cadence.

[mmitche]

The VMR by default does not overwrite the repo's opinion. What's going on here is that by default Microsoft builds non-stable (via what switches we pass in to the top-level script). This default changed for 10.0 earlier this week. But, really this is just allowing the individual repos to do what they want based on their repo defaults. The runtimes and SDKs all default to non-stable. However, this default switch in our CI allowed msbuild to then merge in (it was broken for this reason before), because the upstream packages were now building stable.

So basically, default non-stable builds are broken in the VMR right now. Thinking...

• I don't think we should force any component stable or non
• Building a non-stable runtime+sdk should still be supported (we'll need this for hotfixes, for instance)

I think that a decent solution is to acknowledge that 5104 will fire in non-stable servicing builds, but this is expected and we should disable the warning in this case. Maybe we disable only for components that we don't ship packages for?

[rainersigwald]

acknowledge that 5104 will fire in non-stable servicing builds, but this is expected and we should disable the warning in this case

Makes sense to me.