Skip to content

Commit 0546ff8

Browse files
committed
Merge remote-tracking branch 'dotnet/main' into addContextProvider
2 parents e40d32b + e911690 commit 0546ff8

File tree

4 files changed

+18
-9
lines changed

4 files changed

+18
-9
lines changed

l10n/bundle.l10n.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
"{0}, paste your issue contents as the body of the issue. Don't forget to fill out any details left unfilled.": "{0}, paste your issue contents as the body of the issue. Don't forget to fill out any details left unfilled.",
100100
"Privacy Alert! The contents copied to your clipboard may contain personal data. Prior to posting to GitHub, please remove any personal data which should not be publicly viewable.": "Privacy Alert! The contents copied to your clipboard may contain personal data. Prior to posting to GitHub, please remove any personal data which should not be publicly viewable.",
101101
"Copy issue content again": "Copy issue content again",
102-
"Cannot start collecting Razor logs when {0} is set to {1}. Please set {0} to {2} and then reload your VSCode environment and re-run the report Razor issue command.": "Cannot start collecting Razor logs when {0} is set to {1}. Please set {0} to {2} and then reload your VSCode environment and re-run the report Razor issue command.",
102+
"Cannot start collecting Razor logs when {0} is set to {1}. Please open the output window, choose the \"Razor Log\", and use the gear icon to ensure the log level is set to \"Debug\" or \"Trace\".": "Cannot start collecting Razor logs when {0} is set to {1}. Please open the output window, choose the \"Razor Log\", and use the gear icon to ensure the log level is set to \"Debug\" or \"Trace\".",
103103
"Non Razor file as active document": "Non Razor file as active document",
104104
"Could not determine CSharp content": "Could not determine CSharp content",
105105
"Could not determine Html content": "Could not determine Html content",

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1824,7 +1824,8 @@
18241824
{
18251825
"command": "dotnet.generateAssets",
18261826
"title": "%command.dotnet.generateAssets.currentProject%",
1827-
"category": ".NET"
1827+
"category": ".NET",
1828+
"enablement": "dotnet.server.activationContext == 'Roslyn' || dotnet.server.activationContext == 'OmniSharp'"
18281829
},
18291830
{
18301831
"command": "dotnet.restore.project",

src/coreclrDebug/activate.ts

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ import CompositeDisposable from '../compositeDisposable';
2121
import { BaseVsDbgConfigurationProvider } from '../shared/configurationProvider';
2222
import { omnisharpOptions } from '../shared/options';
2323
import { ActionOption, showErrorMessage } from '../shared/observers/utils/showMessage';
24+
import { getCSharpDevKit } from '../utils/getCSharpDevKit';
25+
import { Command } from 'vscode-languageserver-types';
2426

2527
export async function activate(
2628
thisExtension: vscode.Extension<any>,
@@ -222,12 +224,18 @@ function showInstallErrorMessage(eventStream: EventStream) {
222224
function showDotnetToolsWarning(message: string): void {
223225
const config = vscode.workspace.getConfiguration('csharp');
224226
if (!config.get('suppressDotnetInstallWarning', false)) {
225-
const getDotNetMessage: ActionOption = {
226-
title: vscode.l10n.t('Get the SDK'),
227-
action: async () => {
228-
await vscode.env.openExternal(vscode.Uri.parse('https://dot.net/core-sdk-vscode'));
229-
},
230-
};
227+
const getDotNetMessage: ActionOption | Command =
228+
getCSharpDevKit() !== undefined
229+
? {
230+
title: vscode.l10n.t('Get the SDK'),
231+
command: 'csdevkit.installDotnetSdk',
232+
}
233+
: {
234+
title: vscode.l10n.t('Get the SDK'),
235+
action: async () => {
236+
await vscode.env.openExternal(vscode.Uri.parse('https://dot.net/core-sdk-vscode'));
237+
},
238+
};
231239
const goToSettingsMessage: ActionOption = {
232240
title: vscode.l10n.t('Disable message in settings'),
233241
action: async () => {

src/razor/src/diagnostics/reportIssuePanel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ ${privacyAnchor}
165165
panelBodyContent =
166166
'<p>' +
167167
vscode.l10n.t(
168-
'Cannot start collecting Razor logs when {0} is set to {1}. Please set {0} to {2} and then reload your VSCode environment and re-run the report Razor issue command.',
168+
'Cannot start collecting Razor logs when {0} is set to {1}. Please open the output window, choose the "Razor Log", and use the gear icon to ensure the log level is set to "Debug" or "Trace".',
169169
verbositySettingName,
170170
currentVerbositySettingValue,
171171
neededVerbositySettingValue

0 commit comments

Comments
 (0)