Skip to content

Commit 06460ea

Browse files
committed
review feedback
1 parent 2d8dadc commit 06460ea

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/lsptoolshost/dotnetRuntimeExtensionResolver.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ export class DotnetRuntimeExtensionResolver implements IHostExecutableResolver {
3636
dotnetRuntimePath = path.dirname(dotnetInfo.path);
3737
}
3838

39-
// TODO need exe?
4039
const dotnetExecutableName = this.platformInfo.isWindows() ? 'dotnet.exe' : 'dotnet';
4140
const dotnetExecutablePath = path.join(dotnetRuntimePath, dotnetExecutableName);
4241
if (!existsSync(dotnetExecutablePath)) {

src/shared/reportIssue.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,8 @@ ${generateExtensionTable(extensions)}
6565
</details>
6666
`;
6767

68-
const queryStringPrefix: string = "?";
6968
const issueDefault = "Please paste the output from your clipboard";
70-
const fullUrl = `${issuesUrl}${queryStringPrefix}body=${issueDefault}`;
69+
const fullUrl = `${issuesUrl}?body=${issueDefault}`;
7170
await vscode.env.clipboard.writeText(body);
7271
vscode.env.openExternal(vscode.Uri.parse(fullUrl));
7372
}
@@ -105,7 +104,7 @@ async function getMonoIfPlatformValid(options: Options, monoResolver: IHostExecu
105104
monoVersion = `OmniSharp using mono: ${monoInfo.version}`;
106105
}
107106
catch (error) {
108-
monoVersion = `There is a problem with running OmniSharp on mono: ${error}`;
107+
monoVersion = error instanceof Error ? error.message : `${error}`;
109108
}
110109

111110
return `<details><summary>Mono Information</summary>

0 commit comments

Comments
 (0)