Merge pull request #4385 from Tyriar/patch-1

Avoid white status bar items to ensure contrast

Author: JoeRobich

src/observers/OmnisharpStatusBarObserver.ts

@@ -10,8 +10,7 @@ import { EventType } from "../omnisharp/EventType";
 export enum StatusBarColors {
     Red = 'rgb(218,0,0)',
     Green = 'rgb(0,218,0)',
-    Yellow = 'rgb(218,218,0)',
-    White = 'rgb(256,256,256)'
+    Yellow = 'rgb(218,218,0)'
 }
 
 export class OmnisharpStatusBarObserver extends BaseStatusBarItemObserver {
@@ -34,7 +33,7 @@ export class OmnisharpStatusBarObserver extends BaseStatusBarItemObserver {
                 this.ResetAndHideStatusBar();
                 break;
             case EventType.OmnisharpServerOnStart:
-                this.SetAndShowStatusBar('$(flame)', 'o.showOutput', StatusBarColors.White, 'OmniSharp server is running');
+                this.SetAndShowStatusBar('$(flame)', 'o.showOutput', undefined, 'OmniSharp server is running');
                 break;
             case EventType.DownloadStart:
                 this.SetAndShowStatusBar("$(cloud-download) Downloading packages", '', '', `Downloading package '${(<DownloadStart>event).packageDescription}...' `);

test/unitTests/logging/OmnisharpStatusBarObserver.test.ts

@@ -78,7 +78,6 @@ suite('OmnisharpStatusBarObserver', () => {
         expect(statusBarItem.text).to.be.equal('$(flame)');
         expect(statusBarItem.command).to.equal('o.showOutput');
         expect(statusBarItem.tooltip).to.be.equal('OmniSharp server is running');
-        expect(statusBarItem.color).to.be.equal(StatusBarColors.White);
     });
 
     test('OnServerStop: Status bar is hidden and the attributes are set to undefined', () => {