Rename

Author: akshita31

src/packageManager/PackageFilterer.ts

@@ -10,7 +10,7 @@ import { AbsolutePathPackage } from "./AbsolutePathPackage";
 
 const { filterAsync } = require('node-filter-async');
 
-export async function filterPackages(packages: AbsolutePathPackage[], platformInfo: PlatformInformation): Promise<AbsolutePathPackage[]> {
+export async function getNotInstalledPackagesForPlatform(packages: AbsolutePathPackage[], platformInfo: PlatformInformation): Promise<AbsolutePathPackage[]> {
     let platformPackages = filterPlatformPackages(packages, platformInfo);
     return filterAlreadyInstalledPackages(platformPackages);
 }

src/packageManager/getAbsolutePathPackagesToInstall.ts

@@ -5,10 +5,10 @@
 
 import { PlatformInformation } from "../platform";
 import { AbsolutePathPackage } from "./AbsolutePathPackage";
-import { filterPackages } from "./PackageFilterer";
+import { getNotInstalledPackagesForPlatform } from "./PackageFilterer";
 import { Package } from "./Package";
 
 export async function getAbsolutePathPackagesToInstall(packages: Package[], platformInfo: PlatformInformation, extensionPath: string): Promise<AbsolutePathPackage[]> {
     let absolutePathPackages = packages.map(pkg => AbsolutePathPackage.getAbsolutePathPackage(pkg, extensionPath));
-    return filterPackages(absolutePathPackages, platformInfo);
+    return getNotInstalledPackagesForPlatform(absolutePathPackages, platformInfo);
 }

test/unitTests/Packages/PackageFilterer.test.ts

@@ -4,15 +4,15 @@
  *--------------------------------------------------------------------------------------------*/
 import * as chai from 'chai';
 import { PlatformInformation } from "../../../src/platform";
-import { filterPackages } from "../../../src/packageManager/PackageFilterer";
+import { getNotInstalledPackagesForPlatform } from "../../../src/packageManager/PackageFilterer";
 import { Package } from '../../../src/packageManager/Package';
 import { AbsolutePathPackage } from '../../../src/packageManager/AbsolutePathPackage';
 import { join } from 'path';
 
 let expect = chai.expect;
 const mock = require("mock-fs");
 
-suite('PackageFilterer', () => {
+suite(`${getNotInstalledPackagesForPlatform.name}`, () => {
     let absolutePathPackages: AbsolutePathPackage[];
     let extensionPath = "/ExtensionPath";
     const packages = <Package[]>[
@@ -66,7 +66,7 @@ suite('PackageFilterer', () => {
 
     test('Filters the packages based on Platform Information', async () => {
         let platformInfo = new PlatformInformation("platform2", "architecture2");
-        let filteredPackages = await filterPackages(absolutePathPackages, platformInfo);
+        let filteredPackages = await getNotInstalledPackagesForPlatform(absolutePathPackages, platformInfo);
         expect(filteredPackages.length).to.be.equal(1);
         expect(filteredPackages[0].description).to.be.equal("Platfrom2-Architecture2 uninstalled package");
         expect(filteredPackages[0].platforms[0]).to.be.equal("platform2");
@@ -75,7 +75,7 @@ suite('PackageFilterer', () => {
 
     test('Returns only the packages where install.Lock is not present', async () => {
         let platformInfo = new PlatformInformation("platform1", "architecture1");
-        let filteredPackages = await filterPackages(absolutePathPackages, platformInfo);
+        let filteredPackages = await getNotInstalledPackagesForPlatform(absolutePathPackages, platformInfo);
         expect(filteredPackages.length).to.be.equal(1);
         expect(filteredPackages[0].description).to.be.equal("Platfrom1-Architecture1 uninstalled package");
         expect(filteredPackages[0].platforms[0]).to.be.equal("platform1");