CR feedback: move option into C# options and use better empty array syntax

Author: Ravi Chande

package.json

@@ -323,6 +323,11 @@
           "default": true,
           "description": "Suppress 'hidden' diagnostics (such as 'unnecessary using directives') from appearing in the editor or the Problems pane."
         },
+        "csharp.showReferencesCodeLens": {
+          "type": "boolean",
+          "default": true,
+          "description": "Specifies whether the references CodeLens show be shown."
+        },
         "omnisharp.path": {
           "type": [
             "string",
@@ -373,11 +378,6 @@
           "type": "boolean",
           "default": true,
           "description": "Specifes whether OmniSharp should use VS Code editor settings for C# code formatting (use of tabs, indentation size)."
-        },
-        "omnisharp.showReferencesCodeLens": {
-          "type": "boolean",
-          "default": true,
-          "description": "Specifies whether Omnisharp should show the references CodeLens"
         }
       }
     },

src/features/codeLensProvider.ts

@@ -47,8 +47,7 @@ export default class OmniSharpCodeLensProvider extends AbstractProvider implemen
         const options = Options.Read();
         if (!options.showReferencesCodeLens)
         {
-            let arr: vscode.CodeLens[] = [];
-            return arr;
+            return [];
         }
 
         return serverUtils.currentFileMembersAsTree(this._server, { FileName: document.fileName }, token).then(tree => {

src/omnisharp/options.ts

@@ -52,7 +52,7 @@ export class Options {
 
         const useFormatting = csharpConfig.get<boolean>('format.enable', true);
 
-        const showReferencesCodeLens = omnisharpConfig.get<boolean>('showReferencesCodeLens', true);
+        const showReferencesCodeLens = csharpConfig.get<boolean>('showReferencesCodeLens', true);
 
         return new Options(path, 
             useMono,