Skip to content

Commit 1eda99c

Browse files
committed
another silly mistake
1 parent f1abdba commit 1eda99c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/vscodeLauncher.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,11 @@ async function installExtensions(extensionIds: string[], vscodeCli: string, vsco
7171
for (const extensionId of extensionIds) {
7272
// Workaround for https://github.com/microsoft/vscode/issues/256031 to retry installing the extension with a delay.
7373
let installError: any | undefined = undefined;
74+
let installSucceeded = false;
7475
for (let attempts = 0; attempts < 5; attempts++) {
7576
try {
7677
await installExtension(extensionId, vscodeCli, vscodeArgs);
78+
installSucceeded = true;
7779
break;
7880
} catch (error) {
7981
console.warn(`Failed to install extension ${extensionId}; retrying: ${error}`);
@@ -82,7 +84,7 @@ async function installExtensions(extensionIds: string[], vscodeCli: string, vsco
8284
}
8385
}
8486

85-
if (installError) {
87+
if (!installSucceeded) {
8688
throw installError;
8789
}
8890
}

0 commit comments

Comments
 (0)