Skip to content

Commit 216b395

Browse files
committed
add missing property in params
1 parent f1d84b2 commit 216b395

File tree

3 files changed

+9
-46
lines changed

3 files changed

+9
-46
lines changed

src/razor/src/extension.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,7 @@ export async function activate(
9999
languageServiceClient,
100100
logger
101101
);
102-
const semanticTokenHandler = new SemanticTokensRangeHandler(
103-
documentSynchronizer,
104-
languageServerClient,
105-
languageServiceClient,
106-
documentManager,
107-
logger
108-
);
102+
const semanticTokenHandler = new SemanticTokensRangeHandler(languageServerClient);
109103
const colorPresentationHandler = new ColorPresentationHandler(
110104
documentManager,
111105
languageServerClient,

src/razor/src/semantic/semanticTokensRangeHandler.ts

Lines changed: 6 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ import { RequestType } from 'vscode-languageclient';
88
import { RazorLanguageServerClient } from '../razorLanguageServerClient';
99
import { ProvideSemanticTokensResponse } from './provideSemanticTokensResponse';
1010
import { SerializableSemanticTokensParams } from './serializableSemanticTokensParams';
11-
import { RazorDocumentSynchronizer } from '../document/razorDocumentSynchronizer';
12-
import { RazorDocumentManager } from '../document/razorDocumentManager';
13-
import { RazorLanguageServiceClient } from '../razorLanguageServiceClient';
14-
import { RazorLogger } from '../razorLogger';
1511

1612
export class SemanticTokensRangeHandler {
1713
private static readonly getSemanticTokensRangeEndpoint = 'razor/provideSemanticTokensRange';
@@ -20,18 +16,9 @@ export class SemanticTokensRangeHandler {
2016
ProvideSemanticTokensResponse,
2117
any
2218
> = new RequestType(SemanticTokensRangeHandler.getSemanticTokensRangeEndpoint);
23-
private emptySemanticTokensResponse: ProvideSemanticTokensResponse = new ProvideSemanticTokensResponse(
24-
new Array<Array<number>>(),
25-
-1
26-
);
19+
private emptyTokensInResponse: Array<Array<number>> = new Array<Array<number>>();
2720

28-
constructor(
29-
private readonly documentSynchronizer: RazorDocumentSynchronizer,
30-
protected readonly serverClient: RazorLanguageServerClient,
31-
protected readonly serviceClient: RazorLanguageServiceClient,
32-
protected readonly documentManager: RazorDocumentManager,
33-
protected readonly logger: RazorLogger
34-
) {}
21+
constructor(private readonly serverClient: RazorLanguageServerClient) {}
3522

3623
public async register() {
3724
await this.serverClient.onRequestWithParams<
@@ -49,33 +36,13 @@ export class SemanticTokensRangeHandler {
4936
_semanticTokensParams: SerializableSemanticTokensParams,
5037
_cancellationToken: vscode.CancellationToken
5138
): Promise<ProvideSemanticTokensResponse> {
52-
let version = -1;
53-
try {
54-
const razorDocumentUri = vscode.Uri.parse(_semanticTokensParams.textDocument.uri);
55-
const razorDocument = await this.documentManager.getDocument(razorDocumentUri);
56-
if (razorDocument === undefined) {
57-
return this.emptySemanticTokensResponse;
58-
}
59-
60-
const textDocument = await vscode.workspace.openTextDocument(razorDocumentUri);
61-
version = textDocument.version;
62-
const synchronized = await this.documentSynchronizer.trySynchronizeProjectedDocument(
63-
textDocument,
64-
razorDocument.csharpDocument,
65-
version,
66-
_cancellationToken
67-
);
68-
if (!synchronized) {
69-
return this.emptySemanticTokensResponse;
70-
}
71-
} catch (error) {
72-
this.logger.logWarning(`${SemanticTokensRangeHandler.getSemanticTokensRangeEndpoint} failed with ${error}`);
73-
}
74-
7539
// This is currently a no-op since (1) the default C# semantic tokens experience is already powerful and
7640
// (2) there seems to be an issue with the semantic tokens execute command - possibly either O# not
7741
// returning tokens, or an issue with the command itself:
7842
// https://github.com/dotnet/razor/issues/6922
79-
return new ProvideSemanticTokensResponse(new Array<Array<number>>(), version);
43+
return new ProvideSemanticTokensResponse(
44+
this.emptyTokensInResponse,
45+
_semanticTokensParams.requiredHostDocumentVersion
46+
);
8047
}
8148
}

src/razor/src/semantic/serializableSemanticTokensParams.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import { SerializableRange } from '../rpc/serializableRange';
77
import { SerializableTextDocumentIdentifier } from '../rpc/serializableTextDocumentIdentifier';
88

99
export interface SerializableSemanticTokensParams {
10+
correlationId: string;
1011
textDocument: SerializableTextDocumentIdentifier;
1112
ranges: SerializableRange[];
13+
requiredHostDocumentVersion: number;
1214
}

0 commit comments

Comments
 (0)