Merged PR 476434: Correct CompletionTriggerKind on '@' Trigger Character

'@' is not a valid trigger character for C#/HTML, so whenever user types '@', Razor would pass to Roslyn 'undefined' for the trigger character with trigger kind being 'Invoked' to get the completion list for when user types '@'. With recent improvements to Razor, the trigger kind that is now being passed when user types '@' is 'TriggerCharacter', which will result in an exception. Set the trigger kind to be 'Invoked' if user types '@' to align with previous behavior.

Related work items: #1828754

Author: lonitra

src/razor/src/Completion/RazorCompletionItemProvider.ts

@@ -31,6 +31,7 @@ export class RazorCompletionItemProvider
             // "@" is not a valid trigger character for C# / HTML and therefore we need to translate
             // it into a non-trigger invocation.
             const modifiedTriggerCharacter = context.triggerCharacter === '@' ? undefined : context.triggerCharacter;
+            const triggerKind = context.triggerCharacter === '@' ? CompletionTriggerKind.Invoked : getTriggerKind(context.triggerKind);
 
             let completions: vscode.CompletionList | vscode.CompletionItem[];
 
@@ -42,7 +43,7 @@ export class RazorCompletionItemProvider
             if (language === LanguageKind.CSharp) {
                 const params: CompletionParams = {
                     context: {
-                        triggerKind: getTriggerKind(context.triggerKind),
+                        triggerKind: triggerKind,
                         triggerCharacter: modifiedTriggerCharacter
                     },
                     textDocument: {