Skip to content

Commit 2c12a2b

Browse files
authored
Do not draw attention when evrything is fine (#3144)
1 parent 5b8ecf0 commit 2c12a2b

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/observers/OmnisharpStatusBarObserver.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ import { BaseEvent, DownloadStart, InstallationStart, DownloadProgress, Omnishar
77
import { BaseStatusBarItemObserver } from './BaseStatusBarItemObserver';
88
import { EventType } from "../omnisharp/EventType";
99

10-
export enum StatusBarColors{
10+
export enum StatusBarColors {
1111
Red = 'rgb(218,0,0)',
1212
Green = 'rgb(0,218,0)',
13-
Yellow = 'rgb(218,218,0)'
13+
Yellow = 'rgb(218,218,0)',
14+
White = 'rgb(256,256,256)'
1415
}
1516

1617
export class OmnisharpStatusBarObserver extends BaseStatusBarItemObserver {
@@ -33,7 +34,7 @@ export class OmnisharpStatusBarObserver extends BaseStatusBarItemObserver {
3334
this.ResetAndHideStatusBar();
3435
break;
3536
case EventType.OmnisharpServerOnStart:
36-
this.SetAndShowStatusBar('$(flame)', 'o.showOutput', StatusBarColors.Green, 'OmniSharp server is running');
37+
this.SetAndShowStatusBar('$(flame)', 'o.showOutput', StatusBarColors.White, 'OmniSharp server is running');
3738
break;
3839
case EventType.DownloadStart:
3940
this.SetAndShowStatusBar("$(cloud-download) Downloading packages", '', '', `Downloading package '${(<DownloadStart>event).packageDescription}...' `);

test/unitTests/logging/OmnisharpStatusBarObserver.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ suite('OmnisharpStatusBarObserver', () => {
7878
expect(statusBarItem.text).to.be.equal('$(flame)');
7979
expect(statusBarItem.command).to.equal('o.showOutput');
8080
expect(statusBarItem.tooltip).to.be.equal('OmniSharp server is running');
81-
expect(statusBarItem.color).to.be.equal(StatusBarColors.Green);
81+
expect(statusBarItem.color).to.be.equal(StatusBarColors.White);
8282
});
8383

8484
test('OnServerStop: Status bar is hidden and the attributes are set to undefined', () => {

0 commit comments

Comments
 (0)