Respect the retainVsix flag when running release tests

Author: JoeRobich

CHANGELOG.md

@@ -12,7 +12,6 @@
   * As a workaround, make an edit within the file before using Rename Symbol.
 
 ## 1.23.16 (Not released yet)
-
 * Show decompilation authorization once per install. ([#3982](https://github.com/OmniSharp/omnisharp-vscode/issues/3982), PR: [#4760](https://github.com/OmniSharp/omnisharp-vscode/pull/4760))
 * Launch with first Folder or Solution target found (PR: [#4780](https://github.com/OmniSharp/omnisharp-vscode/pull/4780))
 * Update Debugger Labels (PR: [#4798](https://github.com/OmniSharp/omnisharp-vscode/pull/4798))
@@ -25,7 +24,6 @@
   * handle RecordStructName in semantic highlighting classification ([omnisharp-roslyn#2228](https://github.com/OmniSharp/omnisharp-roslyn/issues/2228) PR: [omnisharp-roslyn#2232](https://github.com/OmniSharp/omnisharp-roslyn/pull/2232))
   * Update CodeStructureService with FileScoped Namespace support ([omnisharp-roslyn#2225](https://github.com/OmniSharp/omnisharp-roslyn/issues/2225) PR: [omnisharp-roslyn#2226](https://github.com/OmniSharp/omnisharp-roslyn/pull/2226))
 
-
 ## 1.23.15 (Aug 31st, 2021)
 * Restore launch target for workspace root when no solution present ([#4691](https://github.com/OmniSharp/omnisharp-vscode/issues/4691), PR: [#4695](https://github.com/OmniSharp/omnisharp-vscode/pull/4695))
 * Don't create launch.json for no select process ([omnisharp-roslyn#4696](https://github.com/OmniSharp/omnisharp-roslyn/issues/4696), PR: [#4699](https://github.com/OmniSharp/omnisharp-vscode/pull/4699))

tasks/offlinePackagingTasks.ts

@@ -44,7 +44,8 @@ gulp.task('vsix:offline:package', async () => {
         throw new Error('Do not build offline packages on windows. Runtime executables will not be marked executable in *nix packages.');
     }
 
-    await cleanAsync(true);
+    //if user does not want to clean up the existing vsix packages
+    await cleanAsync(/* deleteVsix: */ !commandLineOptions.retainVsix);
 
     del.sync(vscodeignorePath);
 
@@ -59,13 +60,6 @@ gulp.task('vsix:offline:package', async () => {
 });
 
 async function doPackageOffline() {
-    if (commandLineOptions.retainVsix) {
-        //if user doesnot want to clean up the existing vsix packages
-        await cleanAsync(false);
-    }
-    else {
-        await cleanAsync(true);
-    }
 
     const packageJSON = getPackageJSON();